Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set storybookUrl action output on rebuild early exit #1134

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node-src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
code: ctx.exitCode,
url: ctx.build?.webUrl,
buildUrl: ctx.build?.webUrl,
storybookUrl: ctx.build?.storybookUrl,
storybookUrl: ctx.build?.storybookUrl || ctx.storybookUrl,

Check warning on line 142 in node-src/index.ts

View check run for this annotation

Codecov / codecov/patch

node-src/index.ts#L142

Added line #L142 was not covered by tests
specCount: ctx.build?.specCount,
componentCount: ctx.build?.componentCount,
testCount: ctx.build?.testCount,
Expand Down
2 changes: 1 addition & 1 deletion node-src/tasks/gitInfo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ export const setGitInfo = async (ctx: Context, task: Task) => {
ctx.rebuildForBuild = result.app.lastBuild;
ctx.storybookUrl = result.app.lastBuild.storybookUrl;
transitionTo(skippedRebuild, true)(ctx, task);
setExitCode(ctx, exitCodes.OK);
ctx.log.info(forceRebuildHint());
ctx.exitCode = 0;
return;
}
}
Expand Down
Loading