Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set storybookUrl action output on rebuild early exit #1134

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Jan 2, 2025

When the action exits early due to an existing passed/accepted build for the commit, set the storybookUrl output to the value of the last build.

📦 Published PR as canary version: 11.22.0--canary.1134.12600266497.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@jmhobbs jmhobbs added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Jan 2, 2025
@jmhobbs jmhobbs self-assigned this Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

📦 Package Size: 5448 KB
✅ Compared to main: 0 KB 9dbaef7 (5448 KB)

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.39%. Comparing base (9dbaef7) to head (05bcf30).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
node-src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1134   +/-   ##
=======================================
  Coverage   69.39%   69.39%           
=======================================
  Files         202      202           
  Lines        7316     7316           
  Branches     1276     1278    +2     
=======================================
  Hits         5077     5077           
  Misses       2216     2216           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmhobbs
Copy link
Contributor Author

jmhobbs commented Jan 2, 2025

First run outputs (not a rebuild)
Screenshot 2025-01-02 at 4 43 02 PM

Second run outputs (rebuild skipped)
Screenshot 2025-01-02 at 4 41 48 PM

@jmhobbs jmhobbs requested a review from a team January 2, 2025 22:43
@jmhobbs jmhobbs marked this pull request as ready for review January 2, 2025 22:43
@jmhobbs jmhobbs added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit f729a2a Jan 3, 2025
24 of 27 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2317-chromauiaction-skipping-rebuild-omit-output-prop branch January 3, 2025 15:50
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.21.0 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants