[ENH] Add support for delete in blockfile #1957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
beggers
approved these changes
Apr 2, 2024
Ishiihara
reviewed
Apr 2, 2024
|
|
||
| blockfile.begin_transaction().unwrap(); | ||
| blockfile.delete(key1.clone()).unwrap(); | ||
| blockfile.commit_transaction().unwrap(); |
There was a problem hiding this comment.
Can we test rollback here as well?
There was a problem hiding this comment.
rollback is unimplemented in this PR. i have a stale stacked PR with proptests
|
|
||
| // See if a delta for the target block already exists, if not create a new one and add it to the transaction state | ||
| // Creating a delta loads the block entirely into memory | ||
| let delta = match transaction_state.get_delta_for_block(&target_block_id) { |
There was a problem hiding this comment.
I am not familiar with the rollback mechanism here. What happens if we need to rollback the delete?
There was a problem hiding this comment.
it discards the whole in-memory state
Ishiihara
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?