Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add record segment #1855

Closed
wants to merge 17 commits into from
Closed

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Mar 9, 2024

Description of changes

This is a draft - will flesh out PR description when I promote.

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • /
  • New functionality
    • Adds EmbeddingRecord value type for serializing embedding records into arrow
    • Adds RecordSegment for generating offset ids and storing core record data

Test plan

How are these changes tested?
Simple unit and sanity tests will be written.

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

github-actions bot commented Mar 9, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Collaborator Author

HammadB commented Mar 9, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite Graphite

@HammadB HammadB mentioned this pull request Mar 9, 2024
1 task
@HammadB HammadB force-pushed the hammad/uint_blockfile_keys_and_values branch from 393a638 to ce86b50 Compare March 11, 2024 18:56
@HammadB HammadB force-pushed the hammad/record_segment branch from 4607ef0 to bce158f Compare March 11, 2024 18:56
@HammadB HammadB force-pushed the hammad/uint_blockfile_keys_and_values branch from ce86b50 to dd0a16a Compare March 12, 2024 04:50
@HammadB HammadB force-pushed the hammad/record_segment branch from d6429cb to b58ee51 Compare March 12, 2024 04:50
@HammadB HammadB force-pushed the hammad/uint_blockfile_keys_and_values branch from dd0a16a to 6492a68 Compare March 12, 2024 18:19
@HammadB HammadB force-pushed the hammad/record_segment branch from b58ee51 to bff6cd3 Compare March 12, 2024 18:19
@HammadB HammadB force-pushed the hammad/uint_blockfile_keys_and_values branch from 6492a68 to eea4c7e Compare March 14, 2024 00:12
@HammadB HammadB force-pushed the hammad/record_segment branch from bff6cd3 to ebf5339 Compare March 14, 2024 00:30
@HammadB HammadB changed the base branch from hammad/uint_blockfile_keys_and_values to main March 14, 2024 00:30
@HammadB HammadB force-pushed the hammad/record_segment branch 2 times, most recently from 6dfd70b to 9420030 Compare March 29, 2024 15:53
@HammadB HammadB force-pushed the hammad/record_segment branch from 9420030 to 7cd8318 Compare April 2, 2024 22:16
@HammadB HammadB changed the base branch from main to hammad/blockfile_delete April 2, 2024 22:16
@HammadB HammadB closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant