-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add record segment #1855
Closed
Closed
[ENH] Add record segment #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This was referenced Mar 9, 2024
Merged
Merged
Merged
Merged
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
HammadB
force-pushed
the
hammad/uint_blockfile_keys_and_values
branch
from
March 11, 2024 18:56
393a638
to
ce86b50
Compare
HammadB
force-pushed
the
hammad/record_segment
branch
from
March 11, 2024 18:56
4607ef0
to
bce158f
Compare
HammadB
force-pushed
the
hammad/uint_blockfile_keys_and_values
branch
from
March 12, 2024 04:50
ce86b50
to
dd0a16a
Compare
HammadB
force-pushed
the
hammad/record_segment
branch
from
March 12, 2024 04:50
d6429cb
to
b58ee51
Compare
HammadB
force-pushed
the
hammad/uint_blockfile_keys_and_values
branch
from
March 12, 2024 18:19
dd0a16a
to
6492a68
Compare
HammadB
force-pushed
the
hammad/record_segment
branch
from
March 12, 2024 18:19
b58ee51
to
bff6cd3
Compare
HammadB
force-pushed
the
hammad/uint_blockfile_keys_and_values
branch
from
March 14, 2024 00:12
6492a68
to
eea4c7e
Compare
HammadB
force-pushed
the
hammad/record_segment
branch
from
March 14, 2024 00:30
bff6cd3
to
ebf5339
Compare
HammadB
changed the base branch from
hammad/uint_blockfile_keys_and_values
to
main
March 14, 2024 00:30
HammadB
force-pushed
the
hammad/record_segment
branch
2 times, most recently
from
March 29, 2024 15:53
6dfd70b
to
9420030
Compare
HammadB
force-pushed
the
hammad/record_segment
branch
from
April 2, 2024 22:16
9420030
to
7cd8318
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a draft - will flesh out PR description when I promote.
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Simple unit and sanity tests will be written.
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?