Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump JS to 1.5.9 #1145

Merged
merged 1 commit into from
Sep 15, 2023
Merged

bump JS to 1.5.9 #1145

merged 1 commit into from
Sep 15, 2023

Conversation

jeffchuber
Copy link
Contributor

Bump to release to 1.5.9 to release #1142

@jeffchuber jeffchuber requested a review from HammadB September 15, 2023 17:16
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@jeffchuber jeffchuber merged commit a0a3c35 into main Sep 15, 2023
@jeffchuber jeffchuber deleted the js_release/1.5.9 branch September 15, 2023 20:32
tazarov pushed a commit to amikos-tech/chroma-core that referenced this pull request Sep 21, 2023
@jeffchuber @tazarov
bump JS to 1.5.9 (chroma-core#1145)
cfff4ab 
Bump to release to 1.5.9 to release
chroma-core#1142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffchuber @HammadB