Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken peer OpenAI dep dependency range #1142

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix broken peer OpenAI dep dependency range #1142

merged 1 commit into from
Sep 15, 2023

Conversation

jacoblee93
Copy link
Contributor

@jacoblee93 jacoblee93 commented Sep 13, 2023 •
edited
Loading

https://semver.npmjs.com/

Screenshot 2023-09-13 at 3 51 28 PM Screenshot 2023-09-13 at 3 51 16 PM

npm strictly checks peer dep ranges, which means the npm install of anything with a peer dep on Chroma was affected by this.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@jeffchuber
Copy link
Contributor

thank you!

@jeffchuber
Copy link
Contributor

@jacoblee93 will merge after tests pass , and then cut a new release tonight - will post here when that is done.

@jacoblee93
Copy link
Contributor Author

Wow that was fast! Thank you!

@jeffchuber
Copy link
Contributor

@jacoblee93 i have to live a certain way

@jacoblee93 jacoblee93 mentioned this pull request Sep 13, 2023
Closed
@jacoblee93
Copy link
Contributor Author

@jeffchuber I think something's up with the last CI action?

@jacoblee93
Copy link
Contributor Author

Bump

@jeffchuber
Copy link
Contributor

@jacoblee93 digging in here this morning - sorry for delay

@jeffchuber jeffchuber merged commit d090ca6 into chroma-core:main Sep 15, 2023
@jeffchuber jeffchuber mentioned this pull request Sep 15, 2023
Merged
jeffchuber added a commit that referenced this pull request Sep 15, 2023
@jeffchuber
bump JS to 1.5.9 (#1145)
a0a3c35 
Bump to release to 1.5.9 to release
#1142
tazarov pushed a commit to amikos-tech/chroma-core that referenced this pull request Sep 21, 2023
@jacoblee93 @tazarov
Fix broken peer OpenAI dep dependency range (chroma-core#1142)
63093bc 
https://semver.npmjs.com/

<img width="1362" alt="Screenshot 2023-09-13 at 3 51 28 PM"
src="https://github.com/chroma-core/chroma/assets/6952323/ab7752f2-9a82-4ea6-8a9b-f92b13b124b0">

<img width="1414" alt="Screenshot 2023-09-13 at 3 51 16 PM"
src="https://github.com/chroma-core/chroma/assets/6952323/c7761348-e499-4541-a775-b5436abff749">

npm strictly checks peer dep ranges, which means the `npm install` of
anything with a peer dep on Chroma was affected by this.
tazarov pushed a commit to amikos-tech/chroma-core that referenced this pull request Sep 21, 2023
@jeffchuber @tazarov
bump JS to 1.5.9 (chroma-core#1145)
cfff4ab 
Bump to release to 1.5.9 to release
chroma-core#1142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchuber jeffchuber jeffchuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacoblee93 @jeffchuber