Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh686 #949

Closed
wants to merge 4 commits into from
Closed

Gh686 #949

wants to merge 4 commits into from

Conversation

eeevans
Copy link

@eeevans eeevans commented Sep 6, 2016

(GH-686) - Add --includepre option to Upgrade command to allow a package which already has a prerelease version installed to be upgraded to the latest prerelease version.

@eeevans
Copy link
Author

eeevans commented Sep 6, 2016

My attempt at squashing didn't work

@ferventcoder
Copy link
Member

ouch on squashing.

@ferventcoder
Copy link
Member

The right thing seems to be to upgrade UNLESS opted out. Whether it is a prerelease or not is not important to an end user. Thoughts?

so choco upgrade all --exclude-installed-prereleases

@eeevans
Copy link
Author

eeevans commented Sep 6, 2016

Yes, that seems a reasonable expectation. I was just wary of changing current functionality without an explicit warning but I can see how it is a more desired functionality.

@ferventcoder
Copy link
Member

@eeevans any updates on flipping this?

@ferventcoder
Copy link
Member

@eeevans Thanks for your contributions, unfortunately we went to the more desired functionality of upgrading packages that are prereleases as well as folks have installed the prerelease, so they want it to upgrade to the latest version (stable or prerelease). The old behavior can be brought back with --exclude-prerelease in 0.10.4+.

@eeevans eeevans deleted the gh686 branch April 18, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants