-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade - when a prerelease is installed, it should upgrade to latest prerelease unless excluded - typically seen in choco upgrade all #686
Comments
In the case of automated unattended scripts, how do you see it working? |
Well, it would be dangerous to ever run "choco upgrade all -y -pre" because then it would upgrade ALL of your stuff to prerelease versions. Perhaps you could add a flag "-includepre" or something that upgrades packages that are already prerelease to a newer prerelease, but leaves stable packages alone (and does not upgrade them to prerelease versions). This flag would allow unintended scripts to function without blocking waiting for y/n while still upgrading your prerlease packages to the latest bits. |
@ScottRFrost that makes way too much sense 👍 |
I'd like to work on this feature and tbh I've already got a lot of the code in place other than the prompting if run without the -includepre switch...I was just wondering if you really want to do that or just spit out info messages informing of the switch to allow it. |
@eeevans let's see what you have so far. |
So this feature will go into 0.10.4 like this - if you have prereleases installed it will upgrade them without needing to explicitly specify prerelease. This will allow everything to upgrade automatically. When it is a prerelease and the latest version is pre or stable, that is what it will upgrade to. When you want the old behavior, just add |
This will be in 0.10.4 |
When a prerelease is installed, it should automatically be upgraded to the newest absolute version (prerelease or stable) unless `--exclude-prerelease` is specified. This means when running `choco upgrade all`, all packages will be upgraded automatically in a way that makes sense.
- upgrade existing package with prerelease available but without prerelease specified - Upgrading an existing package with prerelease available and prerelease specified - Upgrade installed prerelease without prerelease specified - Upgrade installed prerelease with prerelease available with `--exclude-prerelease` - Upgrade all with prereleases installed - Upgrade all with prereleases installed with `--exclude-prerelease` specified
* stable: (GH-1098) Get-FtpFile - change int to long / improve error handling (docs) update generated docs (GH-1187) Get-ChocolateyUnzip - support both archs (GH-1039) Remove quotes before testing path (GH-686) Upgrade Scenarios for Prereleases (GH-686) Upgrade Prereleases (GH-1151) Option - Stop on first package failure (GH-902) Fix: User changed to SYSTEM during env update
Awesome, thanks!
…On Sun, Mar 19, 2017 at 12:28 PM Rob Reynolds ***@***.***> wrote:
Closed #686 <#686>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#686 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAQpTSdFTkB9P4dyFw_v3MdiyshW0S0Eks5rnWWggaJpZM4IEcCy>
.
|
If we upgrade with |
@ferventcoder Or I can file a new issue. |
@bc3tech that would be a separate issue. |
#1957 follow on - upgrade here doesn't also apply to dependencies that are prereleases. |
This should be re-opened:
|
@bc3tech can we please stop asking to reopen an issue? There is maybe a regression, but this issue was fixed in the release it went into. The question of whether it works if the prerelease has prerelease dependencies is a separate issue IMHO. It's likely a bug, but still not the same issue. If it is the same issue, that's called a regression and it still opens as a new issue b/c it cropped back up again later. However, this issue is whether a prerelease would move to find and upgrade and it does, even based on your log. It found the prerelease: Then it was prevented from upgrading based on dependencies. That means we either have a regression or a followup issue to handle prereleases with dependencies. |
If you do "choco upgrade all -y" and it encounters a package that's newer than newest, perhaps it should check prerelease or at least offer to do so.
Current:
chocolatey v0.9.10-beta-20160402 is newer than the most recent.
Proposed:
chocolatey v0.9.10-beta-20160402 is newer than the most recent. Would you like to check prereleases for chocolatey? [y] [n]
Notes
NOTE: admin edit to add notes for breaking change
When you run
choco upgrade all
, it never catches the prereleases. However if you runchoco upgrade all --pre
, it may upgrade some of your stable installs to prereleases. Neither of these situations are desirable. So by default, we've made it so thatchoco upgrade all
just does the right thing, which is to upgrade your stable releases to the latest stable release and your prerelease packages will upgrade to the absolute latest available, whether that be stable or prerelease. If you need to change the behavior back to the old way for upgrade all, simply add the--exclude-prerelease
option.The text was updated successfully, but these errors were encountered: