Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-442) add conditional to prevent removal of unloaded modules #443

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nuget/chocolatey/tools/chocolateyInstall.ps1
Original file line number Diff line number Diff line change
@@ -7,7 +7,9 @@ $modules = Get-ChildItem $toolsPath -Filter *.psm1
$modules | ForEach-Object {
$psm1File = $_.FullName;
$moduleName = $([System.IO.Path]::GetFileNameWithoutExtension($psm1File))
remove-module $moduleName -ErrorAction SilentlyContinue;
if (Get-Module $moduleName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I misunderstanding in that this will actually fail if there is no module?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like it should not error, but is it truthy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done twice I believe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mean this is done more times down in the actual module as well.

remove-module $moduleName -ErrorAction SilentlyContinue;
}
import-module -name $psm1File;
}