(GH-442) add conditional to prevent removal of unloaded modules #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules this is part of a cleaning up content that might be contained within stderr.
| @@ -7,7 +7,9 @@ $modules = Get-ChildItem $toolsPath -Filter *.psm1 | |||
| $modules | ForEach-Object { | |||
| $psm1File = $_.FullName; | |||
| $moduleName = $([System.IO.Path]::GetFileNameWithoutExtension($psm1File)) | |||
| remove-module $moduleName -ErrorAction SilentlyContinue; | |||
| if (Get-Module $moduleName) { | |||
There was a problem hiding this comment.
Am I misunderstanding in that this will actually fail if there is no module?
There was a problem hiding this comment.
Actually it looks like it should not error, but is it truthy?
There was a problem hiding this comment.
This is done twice I believe.
There was a problem hiding this comment.
Sorry, I mean this is done more times down in the actual module as well.
|
Merged into stable at 8840209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part of a cleaning up content that might be contained
within stderr.
Closes #442