Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#3433) Add overload for FindPackages method #3454

Merged
merged 1 commit into from
May 27, 2024

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

Adds back the overload in NuGetList that had been changed to only used the base class.

Motivation and Context

This is reintroduced, as it was causing problems with Chocolatey Licensed Extension.

Testing

Not possible to properly test, until it has been built by soteria.

  1. Install Chocolatey CLI from this PR (officially strong named)
  2. Install Chocolatey Licensed Extension
  3. Attempt to install a package that have dependencies.
  4. Verify no errors are reported.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Related to #3433

@AdmiringWorm AdmiringWorm self-assigned this May 27, 2024
@AdmiringWorm AdmiringWorm requested a review from gep13 May 27, 2024 08:56
@AdmiringWorm AdmiringWorm changed the base branch from develop to release/2.3.0 May 27, 2024 08:56
It was found later when including Chocolatey Licensed Extension that it
would fail to load due to the change to the base source cache context.

As such this commit updates the public API in this case to add the old
method as a deprecated overload.
@gep13 gep13 force-pushed the readd-overload branch from cf9648e to 7bd79e4 Compare May 27, 2024 08:59
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented May 27, 2024

@AdmiringWorm going to take this for a spin directly.

@gep13 gep13 merged commit f3c1215 into chocolatey:release/2.3.0 May 27, 2024
5 checks passed
@AdmiringWorm AdmiringWorm deleted the readd-overload branch May 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants