New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve package dependency lookup when an exact version is defined #3433

Closed

2 tasks done

AdmiringWorm opened this issue Apr 25, 2024 · 1 comment · Fixed by #3435

Closed

2 tasks done

Improve package dependency lookup when an exact version is defined #3433

AdmiringWorm opened this issue Apr 25, 2024 · 1 comment · Fixed by #3435

Assignees

Labels

5 - Released Improvement

Milestone

Member

AdmiringWorm commented Apr 25, 2024 •

edited by pauby

Loading

Checklist

I have verified this is the correct repository for opening this issue.
I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When a package has dependencies and we are installing these, the dependencies are looked up by querying all of the available versions for those dependencies.

This causes unnecessary length of time and issues in some cases.

An additional problem is that when the package being installed has a dependency on a package in the moderation queue or Chocolatey Community Repository, where the package attempted to be installed is approved/exempted, but the dependency has not been approved/exempted, the installation will fail because of this. Even when a specific version is attempted.

Describe The Solution. Why is it needed?

We should update the dependency lookup to be a bit smarter.

When a version range with an inclusive upper limit is specified, then attempt to look up this exact version first. This would cover both inclusive upper limits, and exact version ranges so we do not have to do additional larger queries.

If there is no upper limit then we should attempt to look up the absolute latest version of the package (stable or pre-release dependending on configuration).

When an exclusive upper limit is used, or if the previous two checks fails it should fall back to the grabbing all the available versions of the dependency.

Additional Context

N/A

Related Issues

No response

AdmiringWorm added Improvement 1 - Ready labels

AdmiringWorm added this to the 2.3.0 milestone

AdmiringWorm self-assigned this

AdmiringWorm changed the title ~~Improve how dependencies are looked up when an exact version is defined~~ Improve how dependencies are looked up when an exact version or version with upper limit is defined

AdmiringWorm added 2 - Working and removed 1 - Ready labels

AdmiringWorm changed the title ~~Improve how dependencies are looked up when an exact version or version with upper limit is defined~~ Improve how dependencies are looked up when an exact version is defined

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Update how exact versions are looked up

918f643

This updates the dependency handling of packages to directly look up the
version when an exact version range is being used. This improves
packages that uses such queries, and allows less data being requested
from servers in the cases that we are able to do this determination.

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Enable pre-release when resolving dependencies

This updates the configuration when we are attempting to resolve the
dependencies of a packages when the package requested is explicitly
specified as a pre-release version.

This allows dependencies that are pre-releases to also be resolved
during this cases.

AdmiringWorm mentioned this issue

(#3433) Optimize queries used when resolving dependencies of exact versions #3435

Merged

10 tasks

AdmiringWorm added 3 - Review and removed 2 - Working labels

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Update how exact versions are looked up

36e2f4b

This updates the dependency handling of packages to directly look up the
version when an exact version range is being used. This improves
packages that uses such queries, and allows less data being requested
from servers in the cases that we are able to do this determination.

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Enable pre-release when resolving dependencies

ff1f7c8

This updates the configuration when we are attempting to resolve the
dependencies of a packages when the package requested is explicitly
specified as a pre-release version.

This allows dependencies that are pre-releases to also be resolved
during this cases.

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Update how exact versions are looked up

aa75e06

This updates the dependency handling of packages to directly look up the
version when an exact version range is being used. This improves
packages that uses such queries, and allows less data being requested
from servers in the cases that we are able to do this determination.

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Enable pre-release when resolving dependencies

8e4ba2b

This updates the configuration when we are attempting to resolve the
dependencies of a packages when the package requested is explicitly
specified as a pre-release version.

This allows dependencies that are pre-releases to also be resolved
during this cases.

gep13 pushed a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Update how exact versions are looked up

3a4f6d1

This updates the dependency handling of packages to directly look up the
version when an exact version range is being used. This improves
packages that uses such queries, and allows less data being requested
from servers in the cases that we are able to do this determination.

gep13 pushed a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Enable pre-release when resolving dependencies

f4057b3

This updates the configuration when we are attempting to resolve the
dependencies of a packages when the package requested is explicitly
specified as a pre-release version.

This allows dependencies that are pre-releases to also be resolved
during this cases.

gep13 pushed a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Update how exact versions are looked up

99a2be0

This updates the dependency handling of packages to directly look up the
version when an exact version range is being used. This improves
packages that uses such queries, and allows less data being requested
from servers in the cases that we are able to do this determination.

gep13 pushed a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Enable pre-release when resolving dependencies

7a1dc80

This updates the configuration when we are attempting to resolve the
dependencies of a packages when the package requested is explicitly
specified as a pre-release version.

This allows dependencies that are pre-releases to also be resolved
during this cases.

gep13 pushed a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Update how exact versions are looked up

ebb2c09

This updates the dependency handling of packages to directly look up the
version when an exact version range is being used. This improves
packages that uses such queries, and allows less data being requested
from servers in the cases that we are able to do this determination.

gep13 pushed a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Enable pre-release when resolving dependencies

00f8e1a

This updates the configuration when we are attempting to resolve the
dependencies of a packages when the package requested is explicitly
specified as a pre-release version.

This allows dependencies that are pre-releases to also be resolved
during this cases.

gep13 closed this as completed in #3435

gep13 added a commit that referenced this issue


          Merge pull request #3435 from AdmiringWorm/3433-Improve-how-dependenc…

193b98a

…ies-are-looked-up-when-an-exact-version-or-version-with-upper-limit-is-defined

(#3433) Optimize queries used when resolving dependencies of exact versions

gep13 added 4 - Done and removed 3 - Review labels

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Add overload for FindPackages method

cf9648e

It was found later when including Chocolatey Licensed Extension that it
would fail to load due to the change to the base source cache context.

As such this commit updates the public API in this case to add the old
method as a deprecated overload.

AdmiringWorm mentioned this issue

(#3433) Add overload for FindPackages method #3454

Merged

10 tasks

gep13 pushed a commit to AdmiringWorm/choco that referenced this issue


          (chocolatey#3433) Add overload for FindPackages method

7bd79e4

It was found later when including Chocolatey Licensed Extension that it
would fail to load due to the change to the base source cache context.

As such this commit updates the public API in this case to add the old
method as a deprecated overload.

gep13 added a commit that referenced this issue


          Merge pull request #3454 from AdmiringWorm/readd-overload

f3c1215

(#3433) Add overload for FindPackages method

pauby mentioned this issue

Dependency resolution during install can be slow #3451

Closed

6 tasks

pauby changed the title ~~Improve how dependencies are looked up when an exact version is defined~~ Improve dependency lookup when an exact version is defined

pauby changed the title ~~Improve dependency lookup when an exact version is defined~~ Improve package dependency lookup when an exact version is defined

gep13 added 5 - Released and removed 4 - Done labels

choco-bot commented Jun 5, 2024

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

corbob mentioned this issue

(#3451) Use availablePackages in GetPackageDependencies #3471

Merged

10 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment