Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message that is shown when defaultPushSource configuration value hasn't been set and no explicit source has been provided #3280

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Improve error message that is shown when defaultPushSource configuration value hasn't been set and no explicit source has been provided #3280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chocolatey.tests/infrastructure.app/commands/ChocolateyPushCommandSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public void Should_throw_when_defaultpushsource_is_not_set_and_no_explicit_sourc
errorred.Should().BeTrue();
error.Should().NotBeNull();
error.Should().BeOfType<ApplicationException>();
error.Message.Should().Contain("Default push source configuration is not set.");
error.Message.Should().Contain("The default push source configuration is not set.");
}

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion src/chocolatey/infrastructure.app/commands/ChocolateyPushCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public virtual void Validate(ChocolateyConfiguration configuration)
}
else
{
throw new ApplicationException("Default push source configuration is not set. Please pass a source to push to, such as --source={0}".FormatWith(ApplicationParameters.ChocolateyCommunityFeedPushSource));
throw new ApplicationException("The default push source configuration is not set. Either pass a source to push to, such as `--source=\"'{0}'\"`, or set the `defaultPushSource` configuration value, for example `choco config set --name=\"'defaultPushSource'\" --value=\"'{0}'\"`.".FormatWith(ApplicationParameters.ChocolateyCommunityFeedPushSource));
}
}

Expand Down