Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message that is shown when defaultPushSource configuration value hasn't been set and no explicit source has been provided #3280

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Improve error message that is shown when defaultPushSource configuration value hasn't been set and no explicit source has been provided #3280

merged 1 commit into from
Jul 25, 2023

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jul 24, 2023

Description Of Changes

This commit expands the existing exception message, to explain how the defaultPushSource can be set via the choco config command, rather than only showing how a source can be passed directly.

Motivation and Context

Based on some feedback that came in via Twitter from a package maintainer, providing information about how to set the defaultPushSource via the choco config command would be helpful when in this situation.

Testing

  1. Build the project
  2. Run choco push
  3. Verify that the error output now contains information about how to set defaultPushSource via choco config command

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@gep13
(doc) Improve error message for defaultPushSource
3f80ac8 
Based on some feedback that came in via Twitter from a package
maintainer, providing information about how to set the
defaultPushSource via the choco config command would be helpful when in
this situation.

This command expands the existing exception message, to explain how the
defaultPushSource can be set via the choco config command, rather than
only showing how a source can be passed directly.
@gep13 gep13 added this to the 2.2.0 milestone Jul 24, 2023
@gep13 gep13 requested a review from AdmiringWorm July 24, 2023 14:55
@gep13 gep13 self-assigned this Jul 25, 2023
AdmiringWorm
AdmiringWorm approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit eb03a49 into chocolatey:develop Jul 25, 2023
@AdmiringWorm
Copy link
Member

@gep13, thanks for getting this documentation about the push URL updated. Great work 👍

@gep13 gep13 deleted the improve-error-output branch July 25, 2023 08:38
@gep13 gep13 changed the title (doc) Improve error message for defaultPushSource Improve error message that is shown when defaultPushSource configuration value hasn't been set and no explicit source has been provided Jul 25, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiringWorm AdmiringWorm AdmiringWorm approved these changes

Assignees

@gep13 gep13

Labels
5 - Released Documentation
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gep13 @AdmiringWorm @choco-bot