Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2896) Update from Rx-* to System.Reactive #2963

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

TheCakeIsNaOH
Copy link
Member

Description Of Changes

Updates the various deprecated reactive packages (Rx-Core, Rx-Interfaces, Rx-Linq) to the replacement package ID, System.Reactive

Motivation and Context

Updates deprecated and unlisted packages with the most recent version, during a period of breaking changes.

Testing

Ran NUnit tests

Operating Systems Testing

  • Windows 10 22H2

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #2896

@TheCakeIsNaOH TheCakeIsNaOH force-pushed the gh2896-system-reactive branch from b75d221 to e9d9239 Compare January 13, 2023 15:29
@TheCakeIsNaOH TheCakeIsNaOH force-pushed the gh2896-system-reactive branch from e9d9239 to e01e896 Compare March 16, 2023 14:02
@gep13 gep13 force-pushed the gh2896-system-reactive branch from e01e896 to 2415edf Compare March 16, 2023 14:11
vexx32
vexx32 previously approved these changes Mar 16, 2023
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💖

TheCakeIsNaOH and others added 2 commits March 16, 2023 14:38
Since we are switching to the new System.Reactive package, we need to
update the creditds to reflect no longer using Reactive Extensions.

Also removed the second Table of Contents, as this was causing problems
with updating the document, and it isn't strictly needed.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 0ebedc5 into chocolatey:develop Mar 16, 2023
@gep13
Copy link
Member

gep13 commented Mar 16, 2023

@TheCakeIsNaOH thanks for getting this updated!

@TheCakeIsNaOH TheCakeIsNaOH deleted the gh2896-system-reactive branch March 16, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Rx-* packages to System.Reactive.* packages
3 participants