Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Rx-* packages to System.Reactive.* packages #2896

Closed
TheCakeIsNaOH opened this issue Nov 9, 2022 · 2 comments · Fixed by #2963
Closed

Migrate from Rx-* packages to System.Reactive.* packages #2896

TheCakeIsNaOH opened this issue Nov 9, 2022 · 2 comments · Fixed by #2963

Comments

@TheCakeIsNaOH
Copy link
Member

Is Your Feature Request Related To A Problem? Please describe.

The Rx-core, Rx-linq and Rx-interfaces have all been unlisted. Additionally, they are built for .Net 4.0.

Describe The Solution. Why is it needed?

They have been replaced with the System.Reactive* packages: https://www.nuget.org/packages?q=system.reactive
As far as I am aware in Chocolatey CLI, it should be just a matter of switching out Rx with the equivalent System.Reactive package, as the API surface provided is similar enough that it should be a drop-in replacement. They are built with .Net Standard 2.0, so they will be compatible with moving to building on dotnet in the future.

Additional Context.

I don't know if there are any components that depend on chocolatey.lib and use Rx-*, but if there are, then this change may be a breaking change.

Related Issues

@tapika
Copy link

tapika commented Nov 14, 2022

Please note that those Rx- versions indeed conflict with non Rx-. I had to force for choco ui to use Rx version, but for r2r I'm using non Rx- version.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 10, 2023
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
@gep13 gep13 added this to the 2.0.0 milestone Jan 19, 2023
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Mar 16, 2023
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Mar 16, 2023
gep13 added a commit to TheCakeIsNaOH/choco that referenced this issue Mar 16, 2023
Since we are switching to the new System.Reactive package, we need to
update the creditds to reflect no longer using Reactive Extensions.

Also removed the second Table of Contents, as this was causing problems
with updating the document, and it isn't strictly needed.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Mar 16, 2023
gep13 added a commit to TheCakeIsNaOH/choco that referenced this issue Mar 16, 2023
Since we are switching to the new System.Reactive package, we need to
update the creditds to reflect no longer using Reactive Extensions.

Also removed the second Table of Contents, as this was causing problems
with updating the document, and it isn't strictly needed.
gep13 added a commit that referenced this issue Mar 16, 2023
@gep13 gep13 added 4 - Done and removed 3 - Review labels Mar 16, 2023
@gep13 gep13 changed the title Migrate from Rx-* packages to System.Reactive.* packages. Migrate from Rx-* packages to System.Reactive.* packages Mar 21, 2023
@gep13 gep13 removed the Task label Mar 21, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants