(#508) Change NuGet normal logging to be verbose logging #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the normal informational logging done by NuGet to instead log itself as a verbose message. This is mainly done so outputs of the sources being hit aren't outputted by default to the user in the console.
This commit updates the custom nuget logger to ensure that we get rid of the duplication in the code that is not necessary.
This commit updates the nuget logger being used to make sure that all lines that is passed to the logger is prefixed with the [NuGet] prefix. Not just the first line of the message.
This commit updates the custom nuget project context to reuse our custom logging implementation to get rid of some duplication, and to prevent the need to change the logic in multiple places if there is a need in the future.
AdmiringWorm
force-pushed
the
source-logging
branch
from
08174d5 to
4af6785
Compare
|
Task linked: PROJ-395 Change NuGet logging to be Debug logging |
|
@AdmiringWorm this looks great! Thanks for getting this added! |
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request updates the custom nuget logger we are using to not log normal informational output to the console unless
--verboseis being used.Additionally, this pull request updates the nuget logger, and the custom project context logging functionality to get rid of duplicated code.
Motivation and Context
We do not want to obscure normal output for the user by including the information from NuGet.
While these can be helpful in some cases, hiding it behind a verbose flag by default make sense.
Testing
choco search 7zip.installchoco search 7zip.install --verbose(verbose in this case is synanymous with--detailed).choco info firefoxchoco info firefox --verbosechoco install trid --version 2.24.20221127choco outdatedchoco upgrade allchoco install 7zip.portable --version 19.0 --verbosechoco outdated --verbosechoco upgrade all --verboseOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
#508
https://app.clickup.com/t/20540031/PROJ-395