(#2500) Add E2E tests for template parameters #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: ENGTASKS-1480 Chocolatey CLI |
corbob
requested changes
Sep 15, 2022
There was a problem hiding this comment.
Just a couple of notes, nothing major.
Possibly the biggest thins I'm struggling with in this one is: can we possibly gate these tests without adding a whole bunch of skips... Or should we accept that many of these will possibly fail on 1.1.0 and just leave it at that?
AdmiringWorm
force-pushed
the
templates-parameter-tests
branch
from
21acfd5 to
7f17351
Compare
This commit updates the end to end tests to add regression testing for the incoming template parameters.
corbob
force-pushed
the
templates-parameter-tests
branch
from
7f17351 to
5c78909
Compare
|
Thanks for getting this fixed up @AdmiringWorm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the end to end tests to add regression
testing for the incoming template parameters.
Description Of Changes
This pull request is a followup from the PR #2507 that implemented the functionality to list parameters in templates.
Motivation and Context
To have E2E regression tests available.
Testing
Change Types Made
Related Issue
#2500
https://app.clickup.com/t/20540031/ENGTASKS-1480
Change Checklist