Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List parameters in templates #2500

Closed
TheCakeIsNaOH opened this issue Dec 27, 2021 · 1 comment · Fixed by #2507
Closed

List parameters in templates #2500

TheCakeIsNaOH opened this issue Dec 27, 2021 · 1 comment · Fixed by #2507
Assignees
@AdmiringWorm @TheCakeIsNaOH
Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen
Milestone
1.2.0

Comments

@TheCakeIsNaOH
Copy link
Member

Follow on to this issue: #449

Parameters in templates should be listed. This entails code to find the parameters, and code to display the parameters in the list command. Assuming that the parameters are cached in a file, a format would need to be chosen, and code to write/read these parameters would be needed.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Dec 27, 2021
Merged
8 tasks
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 5, 2022
@TheCakeIsNaOH
(chocolatey#2500) List parameters in templates
3ee21bf 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 5, 2022
@TheCakeIsNaOH
(chocolatey#2500) List parameters in templates
da2be9b 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Jan 5, 2022
Merged
7 tasks
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 10, 2022
@TheCakeIsNaOH
(chocolatey#2500) List parameters in templates
9081dd3 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Mar 21, 2022
@TheCakeIsNaOH
(chocolatey#2500) List parameters in templates
7544d7b 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 27, 2022
@TheCakeIsNaOH
(chocolatey#2500) List parameters in templates
a194aa4 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 27, 2022
@TheCakeIsNaOH
(chocolatey#2500) List parameters in templates
0d817a3 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
@TheCakeIsNaOH TheCakeIsNaOH self-assigned this Jul 30, 2022
@gep13 gep13 added this to the 1.2.0 milestone Aug 11, 2022
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Aug 11, 2022
@TheCakeIsNaOH
(chocolatey#2500) List parameters in templates
2b73662 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Aug 13, 2022
@TheCakeIsNaOH @gep13
(chocolatey#2500) List parameters in templates
565c083 
This adds the ability for the template command to list the parameters
in templates. If the template is installed via a package, the
parameters get cached in a file called .parameters in the template's
directory. This file is ignored by calls to choco new, as it is
excluded from being copied.

There another method added to TokenReplacer to get the parameters via
regex. This keeps the regex in the TokenReplacer class.
gep13 added a commit that referenced this issue Aug 13, 2022
@gep13
Merge pull request #2507 from TheCakeIsNaOH/template-params
1f34adf 
(#2500) List parameters in templates
@gep13 gep13 added 4 - Done and removed 3 - Review labels Aug 13, 2022
@choco-bot choco-bot added the ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added label Aug 24, 2022
@AdmiringWorm AdmiringWorm self-assigned this Sep 15, 2022
@AdmiringWorm AdmiringWorm mentioned this issue Sep 15, 2022
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 15, 2022
@AdmiringWorm
(chocolatey#2500) Add E2E tests for template parameters
21acfd5 
This commit updates the end to end tests to add regression
testing for the incoming template parameters.
@AdmiringWorm AdmiringWorm added IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Sep 15, 2022
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 16, 2022
@AdmiringWorm
(chocolatey#2500) Add E2E tests for template parameters
7f17351 
This commit updates the end to end tests to add regression
testing for the incoming template parameters.
corbob pushed a commit to AdmiringWorm/choco that referenced this issue Sep 20, 2022
@AdmiringWorm @corbob
(chocolatey#2500) Add E2E tests for template parameters
5c78909 
This commit updates the end to end tests to add regression
testing for the incoming template parameters.
corbob added a commit that referenced this issue Sep 20, 2022
@corbob
Merge pull request #2817 from AdmiringWorm/templates-parameter-tests
6f1afc5 
(#2500) Add E2E tests for template parameters
@AdmiringWorm
Copy link
Member

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

(#2500) List parameters in templates TheCakeIsNaOH/choco
4 participants
@gep13 @AdmiringWorm @choco-bot @TheCakeIsNaOH