-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-181) Short confirm prompt / (GH-184) Show a prompt character #204
(GH-181) Short confirm prompt / (GH-184) Show a prompt character #204
Conversation
There is only one thing I don't like about this PR; in ChocolateyLoggers, I added |
Interesting. I'd have to dive back into source to determine what it was ... will be doing that tonight/tomorrow. |
I'm doing that to help (mostly... maybe a little bit to tweak it to my liking too 😄), no pressure, and let me know if I can do anything to ease the process! |
I made both changes (removed |
Don't remove the IConsole comments - I only meant clean it up. |
@ferventcoder I'm really not sure what you mean by "clean it up". Revert the commit (GH-181) Remove |
@christianrondeau remove the commit and clean up the comments so they are not wild and crazy (even if they are in the .NET Framework). I'm in the process of cleaning up some of it was well. |
Or you can forego the cleanup and I will take care of that. |
891f8bb
to
9279ad3
Compare
9279ad3
to
a02cba1
Compare
Ready to merge |
Fixed up and merged into stable at 35747eb. Thanks! |
Solves #181
When prompting for a user yes/no answer, use a short [y/n] representation
.The output looks like this:
I had to do a "hack", where I use the Console directly to output the prompt, and then use a LogFileOnly logger to write the prompt and the answer in the log file. I don't think it's that bad, since InteractivePrompt already depended on an IConsole.ReadLine implementation, so I did the same for IConsole.Write.
Note that it will conflict with #185 (PR #199), so once one of them is merged, I can take care of rebasing the other.