Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not offer a default option when prompting for a user choice #185

Closed
christianrondeau opened this issue Mar 20, 2015 · 1 comment
Closed

Do not offer a default option when prompting for a user choice #185

christianrondeau opened this issue Mar 20, 2015 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Improvement
Milestone
0.9.9.5

Comments

@christianrondeau
Copy link
Contributor

I suggest not offering a default option when offering choices to the end user. This will avoid cases when typing too fast ends up with Enter is not being preceeded by the desired number. It also shortens the output and makes less stuff to read.

There are currently at least two cases where a default option is offered.

Which version of vagrant would you like to uninstall?
 1) None [Default - Press Enter]
 2) 1.6.5
 3) All versions

Also:

Do you want to run the script?
 NOTE: If you choose not to run the script, the installation will
 fail.
 Skip is an advanced option and most likely will never be wanted.

 1) yes
 2) no [Default - Press Enter]
 3) skip

For more details: https://groups.google.com/forum/#!topic/chocolatey/UVncL7PxXRg

(Moved from chocolatey-archive/chocolatey#693)
christianrondeau added a commit to christianrondeau/choco that referenced this issue Mar 24, 2015
@christianrondeau
(chocolateyGH-185) Remove default choice from `InteractivePrompt.prom…
64581ac 
…pt_for_confirmation` and all associated tests
christianrondeau added a commit to christianrondeau/choco that referenced this issue Mar 24, 2015
@christianrondeau
(chocolateyGH-185) Remove require answer from `InteractivePrompt.prom…
171888f 
…pt_for_confirmation` and all associated tests
@christianrondeau christianrondeau mentioned this issue Mar 24, 2015
Closed
christianrondeau added a commit to christianrondeau/choco that referenced this issue Mar 25, 2015
@christianrondeau
(chocolateyGH-185) Remove console prompt default choices
f91a3c9
@christianrondeau christianrondeau mentioned this issue Mar 25, 2015
Closed
ferventcoder pushed a commit that referenced this issue Apr 14, 2015
@christianrondeau @ferventcoder
(GH-185) Remove console prompt default choices
900c23a
ferventcoder added a commit that referenced this issue Apr 14, 2015
@ferventcoder
Merge branch '185-no-prompt-default' into stable
e992c4f 
* 185-no-prompt-default:
  (GH-185) Remove console prompt default choices
@ferventcoder
Copy link
Member

Merged into stable at e992c4f and will be released in 0.9.9.5.

@ferventcoder ferventcoder added this to the 0.9.9.5 milestone Apr 17, 2015
ferventcoder added a commit that referenced this issue Apr 20, 2015
@ferventcoder
Merge branch 'stable'
2ed0d63 
* stable: (22 commits)
  (GH-121) Making Uninstall-ChocolateyZipPackage more robust when
deleting files that were copied during installation of the Zip package
  (doc) update changelog/nuspec
  (GH-238) ApiKey source matching intuitive
  (maint) formatting
  (GH-240) Set CredentialProvider for NuGet
  (GH-240) ChocolateyNugetCredentialProvider
  (GH-240) Add default sources to machine sources
  (maint) Only warn subcommand list if not empty
  (GH-171) Use RedirectedHttpClient
  (GH-240) pass credentials at runtime
  (GH-240)(config) Add machine sources
  (doc) how to quote values
  (GH-230) Export all functions and aliases imported
  (GH-230) Fix Issues with Generate/Remove BinFile
  (GH-185) Remove console prompt default choices
  (GH-186) Uninstall - no prompt for one version
  (GH-182) Ask before printing ps1 scripts
  (GH-187) Show log file path in messages.
  (maint) formatting
  (GH-169) Do not resolve disabled sources
  ...

Conflicts:
	src/chocolatey/infrastructure.app/commands/ChocolateySourceCommand.cs
	src/chocolatey/infrastructure.app/runners/GenericRunner.cs
@ferventcoder ferventcoder self-assigned this Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.9.9.5
3 participants
@ferventcoder @christianrondeau @gep13