(#1962) Use different message on error #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gep13
force-pushed
the
GH-1962-better-error-log
branch
from
f7aff3f to
623f6b3
Compare
gep13
changed the title
Currently, the method logs that the command was "completed" even if it failed. A log that says the step failed would make more sense to the user in this case.
gep13
force-pushed
the
GH-1962-better-error-log
branch
from
623f6b3 to
8e38976
Compare
|
@cowmanjoe thank you very much for taking the time to make this change, really appreciate it! Once the CI builds are completed, we can get this merged in. |
|
@cowmanjoe your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the method logs that the command was "completed" even if it failed. A log that says the step failed would make more sense to the user in this case.
Closes #1962.