(GH-1962) Use a different message for error result in handle_package_…

…result. Currently, the method logs that the command was "completed" even if it failed. A log that says the step failed would make more sense to the user in this case.
chocolatey · Jan 5, 2020 · f7aff3f · f7aff3f
1 parent 564a652
commit f7aff3f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs b/src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs
@@ -338,7 +338,9 @@ public virtual void handle_package_result(PackageResult packageResult, Chocolate
             EnvironmentSettings.reset_environment_variables(config);
             set_pending(packageResult, config);
 
-            this.Log().Info("{0} package files {1} completed. Performing other installation steps.".format_with(packageResult.Name, commandName.to_string()));
+            this.Log().Info(packageResult.ExitCode == 0 
+                ? "{0} package files {1} completed. Performing other installation steps.".format_with(packageResult.Name, commandName.to_string()) 
+                : "{0} package files {1} failed with exit code {3}. Performing other installation steps.".format_with(packageResult.Name, commandName.to_string(), packageResult.ExitCode));
 
             var pkgInfo = get_package_information(packageResult, config);