Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choco pack doesn't include chocolatey-specific metadata #607

Closed
bdukes opened this issue Feb 3, 2016 · 5 comments
Closed

choco pack doesn't include chocolatey-specific metadata #607

bdukes opened this issue Feb 3, 2016 · 5 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.9.10

Comments

@bdukes
Copy link
Contributor

bdukes commented Feb 3, 2016

I believe this started yesterday when I installed the pre-release version of chocolatey and choco.extension package. I currently have version 0.9.10-beta1-116-ga1474ea installed.

I updated the nuspec for hg, adding docsUrl, mailingListUrl, bugTrackerUrl, and releaseNotes (and already had packageSourceUrl specified). However, when I submitted the package, the review indicated I still needed to add those elements. When I review the nupkg that is produced from cpack (or choco pack), I see that the nuspec doesn't include any of those new elements, except releaseNotes.
@bdukes
Copy link
Contributor Author

bdukes commented Feb 3, 2016

The version of nuget available on my path is 3.3.0.212, if that matters.

@ferventcoder
Copy link
Member

@bdukes Chocolatey doesn't use nuget.exe for packing. It uses a built-in Nuget.Core.dll.

@ferventcoder ferventcoder self-assigned this Feb 3, 2016
@ferventcoder ferventcoder added this to the 0.9.10 milestone Feb 3, 2016
@ferventcoder
Copy link
Member

Ah NuGet... :/

@ferventcoder
Copy link
Member

This is fixed and will go out in a beta today.

ferventcoder added a commit that referenced this issue Feb 4, 2016
@ferventcoder
(GH-607) Pack Strips Out Choco Specific Metadata
2d8c717 
In NuGet.Core, manifest creation has a secondary path (an overload to
`Create()` ) in 2.11 and they did not use a shared method to set the
metadata that was alike. The DRY violation has been fixed so both
`Create` methods now go through the same path to set similar metadata.
ferventcoder added a commit that referenced this issue Feb 4, 2016
@ferventcoder
Merge branch 'stable'
5ff288a 
* stable:
  (doc) update CHANGELOG/nuspec
  (GH-604) Add licensed source automatically
  (GH-466) Credential cache validates against base url
  (GH-607) Pack Strips Out Choco Specific Metadata
  (GH-503) Credential request should mask password
@ferventcoder
Copy link
Member

A beta just got pushed with these fixes. https://chocolatey.org/packages/chocolatey/0.9.10-beta-20160204
You can install it immediately if you use -version in the switches, otherwise it will be available in about an hour with the -pre switch.

choco upgrade chocolatey -version 0.9.10-beta-20160204

Would love some verification that this works.

ferventcoder added a commit to chocolatey/nuget-chocolatey that referenced this issue Oct 20, 2016
@ferventcoder
(GH-607) Pack strips out Choco specific metadata
4e28997 
This addresses chocolatey/choco#607 - the
manifest in 2.11 has a secondary path. I find it interesting that both
are there doing nearly the same thing. Fixed this to both use a method
to get Metadata so there is no longer a violation of DRY.
ferventcoder added a commit to chocolatey/nuget-chocolatey that referenced this issue Jan 1, 2018
@ferventcoder
(GH-607) Pack strips out Choco specific metadata
4b90bcc 
This addresses chocolatey/choco#607 - the
manifest in 2.11 has a secondary path. I find it interesting that both
are there doing nearly the same thing. Fixed this to both use a method
to get Metadata so there is no longer a violation of DRY.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Jul 14, 2022
Merged
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
3 participants
@bdukes @ferventcoder @gep13