Reset colors after abnormal exit

[chucker]

If chocolatey exits abnormally, this message appears:

Exiting chocolatey abnormally. Please manually clean up anything that
 was not finished.

Afterwards, the prompt color needs to be reset. (In my case, it was red.)

[ferventcoder]

Ruh roh shaggy. What executable are you using? powershell.exe? cmd.exe? Something else like conemu?

[chucker]

cmd.exe on Windows 10.0.10565

[ferventcoder]

Weird that this is going on. I haven't seen the behavior yet.

[moreandres]

I can reproduce when you interrupt using ctrl-C in the right moment (while choco install showing an error message in red for instance). I am running cmd.exe as admin.

[ferventcoder]

I can reproduce this as well (my last comment was 2015) and I hadn't reproduced it by then. By now I've done it many a time and the problem is once it is exited, there is nothing to reset. Maybe catch and reset before it fully exits. The problem is the code that handles this is in log4net - no idea why it gets stuck.

Currently the only thing to do is close and reopen your shell.

[AdmiringWorm]

@ferventcoder another option could perhaps be to hook into the CancelKeyPressed event, and cancel the currently running task, doing cleanup and then reset the console colors?

Never used it myself though, so I don't know how well that works for that event.

[ferventcoder]

We already have code set for handling the cancel - https://github.com/chocolatey/choco/blob/0c11effebeadbd6bec1d1a16206942aef4204446/src/chocolatey/infrastructure/commandline/ExitScenarioHandler.cs. We went much more low level on that - maybe we didn't have to! All we'd need in there is to ensure we reset colors.

[AdmiringWorm]

I see, in that case.
Shouldn't it be enough to just call Console.ResetColor() in the handler to restore the original colors of the console?

[ferventcoder]

@AdmiringWorm Definitely worth a shot to add. It won't apply if you don't see the warning message though. Sometimes when you call control+c it just exits without a warning. That seems to be when the colors get messed up. So there is probably more to do to ensure that it is capturing those events.

If you want to create a PR for this, we'd accept it!

[AdmiringWorm]

sure thing, I can do that.
But not able to do it until sunday at its earliest, I'll try to have a look around for alternative functionality for this though.

[AdmiringWorm]

It won't apply if you don't see the warning message though. Sometimes when you call control+c it just exits without a warning.

I'm just guessing, but it could be that a different signal is sent instead (especially in cases where the user have done CTRL+C twice in a row).
It's probably the CTRL_SHUTDOWN_EVENT that is sent, which in my understanding is the equivalent of a SIGKILL signal.

[ferventcoder]

That's a one line change in the code I shared above to remove that break; - we are handling that event currently by doing nothing but letting it exit.

There are more graceful ways we could clean up, which I believe is captured in another open ticket here.

[ferventcoder]

This will be in 0.10.9

[john-aws]

Still an issue with chocolatey v1.2.1 on Windows 10. Run choco list, wait a few seconds, then press ctrl+c. The command prompt is now red.

[corbob]

Hi @john-aws,

Thanks for your comment. As this particular issue was closed over 4 years ago, would you mind opening a new issue and filling out the template? Of particular help would probably be a video of the issue happening, as well as consistent reproduction steps.