Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to pick x64/x86 runtime binaries for shimming by architecture without needing PowerShell scripts #1365

Closed
jnm2 opened this issue Jul 18, 2017 · 2 comments
Closed

Ability to pick x64/x86 runtime binaries for shimming by architecture without needing PowerShell scripts #1365

jnm2 opened this issue Jul 18, 2017 · 2 comments
Assignees
@gep13
Labels
5 - Released Improvement shimgen
Milestone
0.10.9

Comments

@jnm2
Copy link

jnm2 commented Jul 18, 2017

In the NuGet world it's a common convention to put platform-specific things in platform-specific folders, both for native resources and managed resources.

I think it would be cool if Chocolatey adopted the convention of ignoring /tools/x64 unless you're doing a 64-bit install, in which case it treats the contents of /tools/x64 as though they were in /tools. Likewise for /tools/x86 and 32-bit installs.

This would remove the need for PowerShell and I could simply distribute:

/tools/x64/my-exe-to-shim.exe
/tools/x86/my-exe-to-shim.exe

Moved from https://github.com/chocolatey/chocolatey.org/issues/526
@ferventcoder ferventcoder added this to the 0.10.8 milestone Aug 6, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.8, 0.10.9 Aug 29, 2017
gep13 added a commit to gep13/choco that referenced this issue Feb 26, 2018
@gep13
(chocolateyGH-1365) Added supported for arch in tools folder
1688cca 
- This allows the creation of an x86 or x64 folder in tools
- Shims will be created, depending on identified arch
- No need for install/uninstall script
@gep13 gep13 mentioned this issue Feb 26, 2018
Merged
gep13 added a commit to gep13/choco that referenced this issue Feb 27, 2018
@gep13
(chocolateyGH-1365) Added supported for arch in tools folder
4b02e05 
- This allows the creation of an x86 or x64 folder in tools
- Shims will be created, depending on identified arch
- No need for install/uninstall script
gep13 added a commit to gep13/choco that referenced this issue Feb 27, 2018
@gep13
(chocolateyGH-1365) Added supported for arch in tools folder
881a76d 
- This allows the creation of an x86 or x64 folder in tools
- Shims will be created, depending on identified arch
- No need for install/uninstall script
gep13 added a commit to gep13/choco that referenced this issue Feb 27, 2018
@gep13
(chocolateyGH-1365) Added supported for arch in tools folder
1ce157c 
- This allows the creation of an x86 or x64 folder in tools
- Shims will be created, depending on identified arch
- No need for install/uninstall script
ferventcoder added a commit that referenced this issue Feb 27, 2018
@ferventcoder
Merge pull request #1512 from gep13/issue-1365
cd8ef68 
(GH-1365) Support architecture folder in tools folder
@ferventcoder
Copy link
Member

Merged into stable at cd8ef68

@gep13
Copy link
Member

gep13 commented Feb 28, 2018

@jnm2 This should be pushed out in 0.10.9 of Chocolatey, would love to hear any feedback that you have on it's usage.

gep13 added a commit that referenced this issue Feb 28, 2018
@gep13
Merge branch 'stable'
1999086 
* stable:
  (GH 1416) Incorrect documentation for Install-ChocolateyInstallPackage
  (GH-1365) Added supported for arch in tools folder
  (maint) Whitespace changes
@ferventcoder ferventcoder changed the title Ability to install from /tools/x64 and /tools/x86 without PowerShell Ability to pick x64/x86 runtime binaries for shimming by architecture without needing PowerShell scripts Mar 4, 2018
ferventcoder added a commit that referenced this issue Mar 25, 2018
@ferventcoder
(GH-1365) Do not warn on missing folders
dc50534 
That would get quite annoying for about 99% of the packages that don't
have architectures in two different folders. Do not provide a warning
if that directory is missing.
ferventcoder added a commit that referenced this issue Mar 25, 2018
@ferventcoder
Merge branch 'stable'
3c81cf8 
* stable:
  (version) 0.10.9
  (doc) update release notes
  (GH-474) Adding reset of console on abnormal exit
  (doc) update release notes
  (GH-1526) Provide friendly messages on exit codes
  (maint) update tab expansion
  (GH-1365) Do not warn on missing folders
  (doc) update release notes
  (GH-1524) Capture password when only user is provided
This was referenced Aug 28, 2021
Closed
Closed
TheCakeIsNaOH added a commit to TheCakeIsNaOH/docs that referenced this issue Oct 12, 2021
@TheCakeIsNaOH
(doc) Add information about archiecture specific shimming
f544e09 
Documents feature added in chocolatey/choco#1365
Fixes chocolatey#229
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Oct 12, 2021
Merged
gep13 pushed a commit to TheCakeIsNaOH/docs that referenced this issue Oct 13, 2021
@TheCakeIsNaOH @gep13
(doc) Add information about archiecture specific shimming
2dc4c82 
Documents feature added in chocolatey/choco#1365
Fixes chocolatey#229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released Improvement shimgen
Projects
None yet
Milestone
0.10.9
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @jnm2