Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono build test failure on systems with a merged usr #2236

Closed
TheCakeIsNaOH opened this issue Apr 16, 2021 · 0 comments · Fixed by #2237
Closed

Mono build test failure on systems with a merged usr #2236

TheCakeIsNaOH opened this issue Apr 16, 2021 · 0 comments · Fixed by #2237
Assignees
Labels
5 - Released BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Milestone

Comments

@TheCakeIsNaOH
Copy link
Member

On some linux systems, system binaries are not under /bin, but under /usr/bin, along with sbin and lib moving to under /usr. The binaries may be symlinked to their original location under /bin as well for backwards compatibility, but when looking up the path to the binary via the $PATH, they are under /usr/bin.
https://wiki.debian.org/UsrMerge

This is an issue as the filesystem test hardcodes ls to be /bin/ls, and fails if it actually located in /usr/bin/ls
https://github.com/chocolatey/choco/blob/master/src/chocolatey.tests/infrastructure/filesystem/DotNetFileSystemSpecs.cs#L219

This should be switched to allow both /bin/ls and /usr/bin/ls

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Apr 16, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The should_find_existing_executable() test has a hardcoded path to the
ls executable, which is incorrect on systems with a merged usr
directory, as they have binaries under /usr/bin instead of under /bin
Switches the test to work with both path.
@gep13 gep13 added this to the 0.10.16 milestone Apr 17, 2021
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Apr 17, 2021
The should_find_existing_executable() test has a hardcoded path to the
ls executable, which is incorrect on systems with a merged usr
directory, as they have binaries under /usr/bin instead of under /bin
Switches the test to work with both paths.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Apr 17, 2021
The should_find_existing_executable() test has a hardcoded path to the
ls executable, which is incorrect on systems with a merged usr
directory, as they have binaries under /usr/bin instead of under /bin
Switches the test to work with both paths.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 19, 2021
The should_find_existing_executable() test has a hardcoded path to the
ls executable, which is incorrect on systems with a merged usr
directory, as they have binaries under /usr/bin instead of under /bin
Switches the test to work with both paths.
@gep13 gep13 linked a pull request Apr 19, 2021 that will close this issue
gep13 added a commit that referenced this issue Apr 19, 2021
(#2236) Mono test work with merged usr systems
@gep13 gep13 closed this as completed Apr 19, 2021
steviecoaster added a commit to steviecoaster/choco that referenced this issue May 11, 2021
…GH2112

* 'GH2112' of https://github.com/steviecoaster/choco:
  (chocolatey#2112) Add msp support to Install helper
  (maint) Switch to using a Regex match
  (maint) Change formatting
  (maint) Remove use of PowerShell aliases
  (maint) Replace " with '
  (chocolatey#2044) Fix for changing $env:Temp
  (chocolatey#2259) Switched to versioned NuGet.Core
  (chocolatey#2111) Deep copy config
  (chocolatey#2244) Add Mac build into main workflow
  (chocolatey#2238) Mono build don't hardcode xbuild path
  (maint) Fix artifact paths on AppVeyor
  (chocolatey#2244) Fix syntax for running on Windows
  (chocolatey#2244) Initial workflow for Windows and Ubuntu
  (doc) Remove Mono instructions for other distributions
  (doc) Add Ubuntu 20.04 mono install instructions
  (chocolatey#2227) Bump Mono version in Dockerfile and README
  (chocolatey#2236) Mono test work with merged usr systems
  (chocolatey#2190) Clarify help for SpecificFolder parameter
  (chocolatey#1962) Use different message on error
  (chocolatey#1861) Improves terminology in help documentation
  (chocolatey#1998) Add authorization header to Get-WebFile
  (maint) Repalce RawGit with raw.githack.com CDN
  (chocolatey#1899) Remove unused variables
  (chocolateyGH-1060) Add BeforeInstall parameter to Install-ChocolateyPackage.ps1
  (maint) Improve log message
  (chocolateyGH-2092) Take all registry keys into account
  (chocolateyGH-1364) Template create .nuspec encoded without BOM
  (chocolatey#1866) Limit pending package removal to top level
  (chocolateyGH-2203) Get-ChocolateyUnzip add unzipLocation alias
  (chocolateyGH-1889) Fix: Removal of ApiKey broken
  (chocolatey#2114) Remove unused variable
  (chocolateyGH-2048) update deprecation note to outdated
  (maint) Spelling and grammar fixes
  (maint) Replace tabs with spaces
  (chocolatey#2078) Skip importing Chocolatey GUI Extension
  (chocolatey#2227) Use latest Mono and Ubuntu on Travis
  (chocolatey#2205) Remove mention of private repository
  (chocolatey#2205) Update remaining URLs to new location
  (maint) Remove unnecessary whitespace
  (chocolatey#2231) Change default repository URL
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update all chocolatey.org/docs URLs
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update automatic-packages docs links
  (doc) Update to prefer # rather than GH-
  (maint) Fix replacement
  (maint) Revert change to earlier commit
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (doc) Update script to Statiq format
  (maint) Add missing backtick in example
  (maint) Added explicit link to new function name
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Remove generated docs files
  (maint) Add docs/generated folder to ignore list
  (chocolateyGH-2105) Update link to Chocolatey workshop
@gep13 gep13 added the NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants