Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ability to install msp patch files using Install-ChocolateyInstallPackage function #2112

Closed
steviecoaster opened this issue Sep 10, 2020 · 0 comments · Fixed by #2113
Closed

Provide ability to install msp patch files using Install-ChocolateyInstallPackage function #2112

steviecoaster opened this issue Sep 10, 2020 · 0 comments · Fixed by #2113
Assignees
@steviecoaster
Labels
5 - Released Improvement
Milestone
0.11.0

Comments

@steviecoaster
Copy link
Contributor

It's trivial to currently work with MSI installers with chocolately, as we natively hook into msiexec's silent installation parameters to complete the installation.

I believe support for msp files directly would be an excellent addition, as it uses the same underlying msiexec installation method, with a slightly modified parameter set.
steviecoaster added a commit to steviecoaster/choco that referenced this issue Sep 10, 2020
@steviecoaster
(chocolateyGH-2112) Add msp installer support to Install-ChocolateyIn…
0d97b6c 
…stallPackage
@steviecoaster steviecoaster mentioned this issue Sep 10, 2020
Merged
@steviecoaster steviecoaster self-assigned this Sep 10, 2020
steviecoaster added a commit to steviecoaster/choco that referenced this issue Apr 19, 2021
@steviecoaster
(chocolatey#2112) Addresses items raised from PR review
f0d40e4 
This commit adds in changes that were requested by @vexx32 as part of his PR review.
steviecoaster added a commit to steviecoaster/choco that referenced this issue Apr 20, 2021
@steviecoaster
(chocolatey#2112) Change additionalInstallArgs match logic
a365a87 
This streamlines the check to use a Regex Or ('|') rather than multiple '-or' clauses.
This will be _slightly_ faster, and maintains readability for maintainers/contributors.
@gep13 gep13 added this to the 0.10.16 milestone May 5, 2021
gep13 pushed a commit to steviecoaster/choco that referenced this issue May 5, 2021
@steviecoaster @gep13
(chocolateyGH-2112) Add msp installer support to Install-ChocolateyIn…
38bc768 
…stallPackage
gep13 pushed a commit to steviecoaster/choco that referenced this issue May 5, 2021
@steviecoaster @gep13
(chocolatey#2112) Addresses items raised from PR review
5c6b011 
This commit adds in changes that were requested by @vexx32 as part of his PR review.
gep13 pushed a commit to steviecoaster/choco that referenced this issue May 5, 2021
@steviecoaster @gep13
(chocolatey#2112) Change additionalInstallArgs match logic
0c6cb0c 
This streamlines the check to use a Regex Or ('|') rather than multiple '-or' clauses.
This will be _slightly_ faster, and maintains readability for maintainers/contributors.
gep13 pushed a commit to steviecoaster/choco that referenced this issue May 5, 2021
@steviecoaster @gep13
(chocolatey#2112) Add msp support to Install helper
c6b0f5c
gep13 added a commit to steviecoaster/choco that referenced this issue May 5, 2021
@gep13
(chocolatey#2112) Add msp support to Install helper
2f07a6c 
It's trivial to currently work with MSI installers with chocolately, as
we natively hook into msiexec's silent installation parameters to
complete the installation.

Support for msp files directly is a simple addition, as it uses the same
underlying msiexec installation method, with a slightly modified
parameter set.
steviecoaster added a commit to steviecoaster/choco that referenced this issue May 11, 2021
@steviecoaster
Merge branch 'GH2112' of https://github.com/steviecoaster/choco into …
61102d6 
…GH2112

* 'GH2112' of https://github.com/steviecoaster/choco:
  (chocolatey#2112) Add msp support to Install helper
  (maint) Switch to using a Regex match
  (maint) Change formatting
  (maint) Remove use of PowerShell aliases
  (maint) Replace " with '
  (chocolatey#2044) Fix for changing $env:Temp
  (chocolatey#2259) Switched to versioned NuGet.Core
  (chocolatey#2111) Deep copy config
  (chocolatey#2244) Add Mac build into main workflow
  (chocolatey#2238) Mono build don't hardcode xbuild path
  (maint) Fix artifact paths on AppVeyor
  (chocolatey#2244) Fix syntax for running on Windows
  (chocolatey#2244) Initial workflow for Windows and Ubuntu
  (doc) Remove Mono instructions for other distributions
  (doc) Add Ubuntu 20.04 mono install instructions
  (chocolatey#2227) Bump Mono version in Dockerfile and README
  (chocolatey#2236) Mono test work with merged usr systems
  (chocolatey#2190) Clarify help for SpecificFolder parameter
  (chocolatey#1962) Use different message on error
  (chocolatey#1861) Improves terminology in help documentation
  (chocolatey#1998) Add authorization header to Get-WebFile
  (maint) Repalce RawGit with raw.githack.com CDN
  (chocolatey#1899) Remove unused variables
  (chocolateyGH-1060) Add BeforeInstall parameter to Install-ChocolateyPackage.ps1
  (maint) Improve log message
  (chocolateyGH-2092) Take all registry keys into account
  (chocolateyGH-1364) Template create .nuspec encoded without BOM
  (chocolatey#1866) Limit pending package removal to top level
  (chocolateyGH-2203) Get-ChocolateyUnzip add unzipLocation alias
  (chocolateyGH-1889) Fix: Removal of ApiKey broken
  (chocolatey#2114) Remove unused variable
  (chocolateyGH-2048) update deprecation note to outdated
  (maint) Spelling and grammar fixes
  (maint) Replace tabs with spaces
  (chocolatey#2078) Skip importing Chocolatey GUI Extension
  (chocolatey#2227) Use latest Mono and Ubuntu on Travis
  (chocolatey#2205) Remove mention of private repository
  (chocolatey#2205) Update remaining URLs to new location
  (maint) Remove unnecessary whitespace
  (chocolatey#2231) Change default repository URL
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update all chocolatey.org/docs URLs
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update automatic-packages docs links
  (doc) Update to prefer # rather than GH-
  (maint) Fix replacement
  (maint) Revert change to earlier commit
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (doc) Update script to Statiq format
  (maint) Add missing backtick in example
  (maint) Added explicit link to new function name
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Remove generated docs files
  (maint) Add docs/generated folder to ignore list
  (chocolateyGH-2105) Update link to Chocolatey workshop
steviecoaster added a commit to steviecoaster/choco that referenced this issue May 11, 2021
@steviecoaster
(chocolateyGH-2112) Correct regression introduced by previous commit.
d697cac 
In a previous commit we dropped the initial arguments for an msi file. This commit corrects that
regression and sets them properly ahead of additional processing. It also applies a small formatting
fix to an if statement.
gep13 added a commit to steviecoaster/choco that referenced this issue May 12, 2021
@gep13
(chocolatey#2112) Add msp support to Install helper
1f2299c 
It's trivial to currently work with MSI installers with chocolately, as
we natively hook into msiexec's silent installation parameters to
complete the installation.

Support for msp files directly is a simple addition, as it uses the same
underlying msiexec installation method, with a slightly modified
parameter set.
gep13 added a commit to steviecoaster/choco that referenced this issue May 12, 2021
@gep13 @steviecoaster
(chocolatey#2112) Add msp support to Install helper
f68a242 
It's trivial to currently work with MSI installers with chocolately, as
we natively hook into msiexec's silent installation parameters to
complete the installation.

Support for msp files directly is a simple addition, as it uses the same
underlying msiexec installation method, with a slightly modified
parameter set.

Co-authored-by:  Stephen Valdinger <[email protected]>
gep13 added a commit that referenced this issue May 12, 2021
@gep13
Merge pull request #2113 from steviecoaster/GH2112
a992a82 
(GH-2112) Add msp installer support to Install-ChocolateyInstallPackage
@gep13 gep13 closed this as completed May 12, 2021
gep13 added a commit that referenced this issue May 13, 2021
@gep13
Merge branch 'stable' into master
af3e8c9 
* stable: (44 commits)
  (#2220) Add convert command to allowed list
  (#2049) Add --version to top level tab expansion
  (#944) Add tab expansion for help command
  (#357) Add tab expansion for export command
  (#357) Ensure to use full file path
  (maint) fix typo
  (maint) formatting
  (doc) pin: show reasons option
  (maint) log message on nuget conflict
  (#2270) Update to NuGet.exe 5.9.1.11
  (#2049) Add version option to help text
  (#2112) Add msp support to Install helper
  (maint) Change formatting
  (maint) Switch to using a Regex match
  (#2244) Add badge for latest docker semver version
  (#2244) Add status badge for GitHub Action
  (#2261) Minor tweak to remove extra space
  (#2261) Updates License Headers Copyright to 2021
  (#2263) Pack on Mono pass absolute path to PackageBuilder
  (#2244) Add Docker build into main workflow
  ...
@gep13 gep13 changed the title Helper Install-ChocolateyInstallPackage should support msp patch files Provide ability to install msp patch files using Install-ChocolateyInstallPackage function May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steviecoaster steviecoaster

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

(#2112) Add msp installer support to Install-ChocolateyInstallPackage steviecoaster/choco
2 participants
@gep13 @steviecoaster