Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-85) Pass the source to cChocoPackageInstallerSet correctly #86

Conversation

Jark
Copy link
Contributor

@Jark Jark commented Jun 22, 2017

The cChocoPackageInstallerSet resource only provides the Source
parameter to the first package being installed. This occurred due to
historical reasons where the Source would be added to the system
rather than being specified.

This commit will pass the Source in for every package.

The cChocoPackageInstallerSet resource only provides the Source
parameter to the first package being installed. This occurred due to
historical reasons where the Source would be added to the system
rather than being specified.

This commit will pass the Source in for every package.
Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ferventcoder ferventcoder merged commit aecb4db into chocolatey:development Jun 22, 2017
jrdnr added a commit to jrdnr/cChoco that referenced this pull request Nov 14, 2017
Added AutoUpgrade Parameter in keeping with the current format.  This is not compatible with curret Test-TargetResource code per issue chocolatey#96.
Need to either revert back to Pre chocolatey#86 and go from their or rebuild tests to alow null/empty parameters to be specified in the MOF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants