Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The source is only be specified once in cChocoPackageInstallerSet #85

Closed
Jark opened this issue Jun 22, 2017 · 1 comment
Closed

The source is only be specified once in cChocoPackageInstallerSet #85

Jark opened this issue Jun 22, 2017 · 1 comment
Labels
4 - Done Bug Priority_HIGH
Milestone
2.4.0

Comments

@Jark
Copy link
Contributor

Jark commented Jun 22, 2017

The cChocoPackageInstallerSet resource only provides the Source parameter to the first package being installed, I believe this is because in the past it would add the Source as a new Chocolatey Source.

I plan on adding a pull request shortly to fix this issue.
@Jark Jark changed the title The source will only be set once in cChocoPackageInstallerSet The source will only be specified once in cChocoPackageInstallerSet Jun 22, 2017
@Jark Jark changed the title The source will only be specified once in cChocoPackageInstallerSet The source is only be specified once in cChocoPackageInstallerSet Jun 22, 2017
Jark added a commit to Jark/cChoco that referenced this issue Jun 22, 2017
@Jark
(chocolateyGH-85) Pass the source to cChocoPackageInstallerSet correctly
2ed30be 
The cChocoPackageInstallerSet resource only provides the Source
parameter to the first package being installed. This occurred due to
historical reasons where the Source would be added to the system
rather than being specified.

This commit will pass the Source in for every package.
ferventcoder added a commit that referenced this issue Jun 22, 2017
@ferventcoder
Merge pull request #86 from Jark/pass-in-source-parameter-correctly-i…
aecb4db 
…n-cchocopackageinstallset

(GH-85) Pass the source to cChocoPackageInstallerSet correctly
@ferventcoder
Copy link
Member

This is fixed for the next release as well.

@ferventcoder ferventcoder added this to the 2.4.0 milestone Jun 22, 2017
ferventcoder added a commit that referenced this issue Aug 29, 2017
@ferventcoder
Merge branch 'development'
aeb501f 
* development:
  (GH-71) Implemented cChocoFeature
  (GH-87) Moved to using reduced output
  (maint) formatting
  (GH-70) Apply Apache v2 Licensing
  (GH-85) Pass the source to cChocoPackageInstallerSet correctly
  (GH-44) Pass the Source to choco correctly
  Added version to example
  (GH-77) Push to gallery on new tags
  (maint) formatting
  (GH-72) PowerShell scripts in format for signing
jrdnr added a commit to jrdnr/cChoco that referenced this issue Sep 1, 2017
@jrdnr
Merge branch 'development' into (chocolateyGH-90)_Cache_InstalledPack…
624a8fb 
…ages_for_faster_run

* development:
  (chocolateyGH-87) Moved to using reduced output
  (maint) formatting
  (chocolateyGH-70) Apply Apache v2 Licensing
  (chocolateyGH-85) Pass the source to cChocoPackageInstallerSet correctly
  (chocolateyGH-44) Pass the Source to choco correctly
  Added version to example
  (chocolateyGH-77) Push to gallery on new tags
  (maint) formatting
  (chocolateyGH-72) PowerShell scripts in format for signing

# Conflicts:
#	DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - Done Bug Priority_HIGH
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@ferventcoder @Jark