(#147) Update Authenticode signing certificate subject name and allow setting it via an environment variable #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
reviewed
May 10, 2024
This updates the default Authenticode subject name to match what it changed to during the recent renewal process. It also enables setting this same name via an Environment Variable so that no changes are needed urgently if it changes again in the future.
Windos
force-pushed
the
GH-147/update-authenticode-signing-subject-name
branch
from
b1dd31f to
32aa0d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR updates the default subject name for the Authenticode signing certificate from
Chocolatey Software, Inc.toChocolatey Software, Incand also enables overriding this subject name via an environment variable.Motivation and Context
During the renewal of the Authenticode signing certificate, the subject name changed slightly, and so signing fails due to not being able to find the matching certificate.
This change necessitates updating the version of this recipe used in projects, to avoid this situation in the future the option of providing an environment variable was introduced.
Testing
I'm not 100% sure on how to best test this
Operating Systems Testing
N/A
Change Types Made
Change Checklist
Related Issue
Fixes #147