Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting Authenticode signing certificate subject name by Environment Variable and update default value #147

Closed
2 tasks done
Windos opened this issue May 9, 2024 · 1 comment · Fixed by #148
Closed
2 tasks done

Add support for setting Authenticode signing certificate subject name by Environment Variable and update default value #147

Windos opened this issue May 9, 2024 · 1 comment · Fixed by #148
Assignees
@Windos
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.28.0

Comments

@Windos
Copy link
Member

Windos commented May 9, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

The subject name on an Authenticode signing certificate may not always be the current hard coded value, and the chances of this being the case is heightened during certificate renewal.

If the subject name of the new certificate does not match the hard coded value, then signing will fail.

Describe The Solution. Why is it needed?

It should be possible to set this subject name via an environment variable so that it can be changes without needing to update the recipe version being in used.

Additional Context

N/A

Related Issues

  • ClickUp: ENGTASKS-3633
Windos added a commit to Windos/Chocolatey.Cake.Recipe that referenced this issue May 10, 2024
@Windos
(chocolatey#147) Update cert subject name + set via env var
b1dd31f 
This updates the default Authenticode subject name to match what it
changed to during the recent renewal process. It also enables setting
this same name via an Environment Variable so that no changes are needed
urgently if it changes again in the future.
@Windos Windos mentioned this issue May 10, 2024
Merged
10 tasks
Windos added a commit to Windos/Chocolatey.Cake.Recipe that referenced this issue May 10, 2024
@Windos
(chocolatey#147) Update cert subject name + set via env var
32aa0d0 
This updates the default Authenticode subject name to match what it
changed to during the recent renewal process. It also enables setting
this same name via an Environment Variable so that no changes are needed
urgently if it changes again in the future.
@gep13 gep13 added this to the 0.28.0 milestone May 13, 2024
@gep13 gep13 added Improvement Issues that enhances existing functionality, or adds new features 3 - Review Code has been added, and is available for review as a pull request labels May 13, 2024
gep13 added a commit that referenced this issue May 13, 2024
@gep13
Merge pull request #148 from Windos/GH-147/update-authenticode-signin…
043be76 
…g-subject-name

(#147) Update Authenticode signing certificate subject name and allow setting it via an environment variable
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels May 13, 2024
gep13 added a commit that referenced this issue May 16, 2024
@gep13
Merge branch 'release/0.28.0'
8a699ac 
* release/0.28.0:
  (#149) Switch to only signing when required
  (#147) Update cert subject name + set via env var
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels May 16, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.28.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Windos Windos

Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.28.0
3 participants
@gep13 @choco-bot @Windos