Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent about what tasks can be overridden #61

Closed
gep13 opened this issue May 9, 2022 · 1 comment
Closed

Be consistent about what tasks can be overridden #61

gep13 opened this issue May 9, 2022 · 1 comment
Assignees
@gep13
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.13.0

Comments

@gep13
Copy link
Member

gep13 commented May 9, 2022

For some tasks, like Run-InspectCode, there is a direct parameter which can be set shouldRunInspectCode which prevents this task from being executed. For other tasks, this is not possible. We should be consistent about exactly what tasks can be overridden, ideally all of them, via the parameters passed into the recipe.cake file.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label May 9, 2022
@gep13 gep13 added this to the 0.13.0 milestone May 9, 2022
@gep13 gep13 self-assigned this May 9, 2022
@gep13 gep13 closed this as completed May 9, 2022
gep13 added a commit that referenced this issue May 9, 2022
@gep13
(#61) Alphabetical all the things!
e8de4ae 
Made all the properties and usage of them within the parameters.cake
file alphabetical. This should make them easier to find going forward.

Also, for similar reasons, changes TransifexEnabled to
ShouldRunTransifex.
gep13 added a commit that referenced this issue May 9, 2022
@gep13
(#61) Add new criteria to tasks
6435abf 
To allow these tasks to be overridden in the recipe.cake file, in the
same way that can be done for other tasks.  This now means that all
tasks can be overridden.
gep13 added a commit that referenced this issue May 9, 2022
@gep13
(#61) Renamed ShouldPublishGitHub
f0ffcac 
To reflect what is actually happening, i.e. running GitReleaseManager.
gep13 added a commit that referenced this issue May 9, 2022
@gep13
(#61) Add override for OpenCover
1ac87f7 
To allow preventing the execution of OpenCover, which can cause
problems in some scenarios.
gep13 added a commit that referenced this issue May 9, 2022
@gep13
Merge branch 'release/0.13.0'
267332c 
* release/0.13.0:
  (#61) Add override for OpenCover
  (#62) ToLower() to argument
  (maint) Formatting
  (#62) Don't run any unit tests when argument set
  (maint) Correct spelling of NuGet
  (maint) Renamed CanUseGitReleaseManager property
  (#61) Renamed ShouldPublishGitHub
  (#61) Add new criteria to tasks
  (#61) Alphabetical all the things!
  (maint) Renamed all DotNetCore tasks
  (maint) Remove Upload-Artifacts-Task
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.13.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot