(#61) Renamed ShouldPublishGitHub

To reflect what is actually happening, i.e. running GitReleaseManager.
chocolatey · May 9, 2022 · f0ffcac · f0ffcac
1 parent 6435abf
commit f0ffcac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Chocolatey.Cake.Recipe/Content/gitreleasemanager.cake b/Chocolatey.Cake.Recipe/Content/gitreleasemanager.cake
@@ -64,7 +64,7 @@ BuildParameters.Tasks.PublishGitHubReleaseTask = Task("Publish-GitHub-Release")
     .WithCriteria(() => !BuildParameters.IsPullRequest, "Skipping because this is pull request")
     .WithCriteria(() => BuildParameters.BranchType == BranchType.Master || BuildParameters.BranchType == BranchType.Release || BuildParameters.BranchType == BranchType.HotFix, "Skipping because this is not a releasable branch")
     .WithCriteria(() => BuildParameters.IsTagged, "Skipping because this is not a tagged build")
-    .WithCriteria(() => BuildParameters.ShouldPublishGitHub, "Skipping because this publishing GitHub Release is disabled via parameters (perhaps the default value?")
+    .WithCriteria(() => BuildParameters.ShouldRunGitReleaseManager, "Skipping because this publishing running GitReleaseManager is disabled via parameters (perhaps the default value?")
     .Does(() => RequireTool(BuildParameters.IsDotNetBuild || BuildParameters.PreferDotNetGlobalToolUsage ? ToolSettings.GitReleaseManagerGlobalTool : ToolSettings.GitReleaseManagerTool, () => {
         if (BuildParameters.CanUseGitReleaseManager)
         {

diff --git a/Chocolatey.Cake.Recipe/Content/parameters.cake b/Chocolatey.Cake.Recipe/Content/parameters.cake
@@ -67,14 +67,14 @@ public static class BuildParameters
     public static bool ShouldDownloadFullReleaseNotes { get; private set;}
     public static bool ShouldDownloadMilestoneReleaseNotes { get; private set;}
     public static bool ShouldObfuscateOutputAssemblies { get; private set; }
-    public static bool ShouldPublishGitHub { get; private set; }
     public static bool ShouldPublishPreReleasePackages { get; private set; }
     public static bool ShouldPublishReleasePackages { get; private set; }
     public static bool ShouldReportCodeCoverageMetrics { get; private set; }
     public static bool ShouldReportUnitTestResults { get; private set; }
     public static bool ShouldRunChocolatey { get; private set; }
     public static bool ShouldRunDotNetPack { get; private set; }
     public static bool ShouldRunDotNetTest { get; private set; }
+    public static bool ShouldRunGitReleaseManager { get; private set; }
     public static bool ShouldRunGitVersion { get; private set; }
     public static bool ShouldRunILMerge { get; private set; }
     public static bool ShouldRunInspectCode { get; private set; }
@@ -184,14 +184,14 @@ public static class BuildParameters
         context.Information("ShouldDownloadFullReleaseNotes: {0}", BuildParameters.ShouldDownloadFullReleaseNotes);
         context.Information("ShouldDownloadMilestoneReleaseNotes: {0}", BuildParameters.ShouldDownloadMilestoneReleaseNotes);
         context.Information("ShouldObfuscateOutputAssemblies: {0}", BuildParameters.ShouldObfuscateOutputAssemblies);
-        context.Information("ShouldPublishGitHub: {0}", BuildParameters.ShouldPublishGitHub);
         context.Information("ShouldPublishPreReleasePackages: {0}", BuildParameters.ShouldPublishPreReleasePackages);
         context.Information("ShouldPublishReleasePackages: {0}", BuildParameters.ShouldPublishReleasePackages);
         context.Information("ShouldReportCodeCoverageMetrics: {0}", BuildParameters.ShouldReportCodeCoverageMetrics);
         context.Information("ShouldReportUnitTestResults: {0}", BuildParameters.ShouldReportUnitTestResults);
         context.Information("ShouldRunChocolatey: {0}", BuildParameters.ShouldRunChocolatey);
         context.Information("ShouldRunDotNetPack: {0}", BuildParameters.ShouldRunDotNetPack);
         context.Information("ShouldRunDotNetTest: {0}", BuildParameters.ShouldRunDotNetTest);
+        context.Information("ShouldRunGitReleaseManager: {0}", BuildParameters.ShouldRunGitReleaseManager);
         context.Information("ShouldRunGitVersion: {0}", BuildParameters.ShouldRunGitVersion);
         context.Information("ShouldRunILMerge: {0}", BuildParameters.ShouldRunILMerge);
         context.Information("ShouldRunInspectCode: {0}", BuildParameters.ShouldRunInspectCode);
@@ -252,14 +252,14 @@ public static class BuildParameters
         bool shouldDownloadFullReleaseNotes = false,
         bool shouldDownloadMilestoneReleaseNotes = false,
         bool shouldObfuscateOutputAssemblies = true,
-        bool shouldPublishGitHub = false,
         bool shouldPublishPreReleasePackages = true,
         bool shouldPublishReleasePackages = true,
         bool shouldReportCodeCoverageMetrics = true,
         bool shouldReportUnitTestResults = true,
         bool shouldRunChocolatey = true,
         bool shouldRunDotNetPack = false,
         bool shouldRunDotNetTest = true,
+        bool shouldRunGitReleaseManager = false,
         bool shouldRunGitVersion = true,
         bool shouldRunILMerge = true,
         bool shouldRunInspectCode = true,
@@ -349,7 +349,7 @@ public static class BuildParameters
         ShouldDownloadFullReleaseNotes = shouldDownloadFullReleaseNotes;
         ShouldDownloadMilestoneReleaseNotes = shouldDownloadMilestoneReleaseNotes;
         ShouldObfuscateOutputAssemblies = shouldObfuscateOutputAssemblies;
-        ShouldPublishGitHub = shouldPublishGitHub;
+        ShouldRunGitReleaseManager = shouldRunGitReleaseManager;
         ShouldPublishPreReleasePackages = shouldPublishPreReleasePackages;
         ShouldPublishReleasePackages = shouldPublishReleasePackages;
         ShouldReportCodeCoverageMetrics = shouldReportCodeCoverageMetrics;