Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure usage of direct conditions when using WithCriteria on tasks #50

Closed
gep13 opened this issue May 5, 2022 · 1 comment
Closed

Ensure usage of direct conditions when using WithCriteria on tasks #50

gep13 opened this issue May 5, 2022 · 1 comment
Assignees
@gep13
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.8.0

Comments

@gep13
Copy link
Member

gep13 commented May 5, 2022

When defining WithCriteria on tasks, a single (or at most two) conditions should be used. That way, a reason can easily be provided in the build output as to why a task was skipped.

Remove the usage of a method like ShouldPublishGitHub() that contains lots of conditions, as then it becomes hard to understand exactly why a task was skipped during the build execution.

While updating this, it makes sense to ensure consistency in the reasons provided for skipping a task.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label May 5, 2022
@gep13 gep13 added this to the 0.8.0 milestone May 5, 2022
@gep13 gep13 self-assigned this May 5, 2022
@gep13 gep13 closed this as completed May 5, 2022
gep13 added a commit that referenced this issue May 5, 2022
@gep13
(#50) Use specific conditions in WithCriteria
b77f196 
This means that when a task is skipped it will be perfectly clear about
_why_ it was skipped, rather than havig to reason about the multiple
conditions that exist within the helper methods.
gep13 added a commit that referenced this issue May 5, 2022
@gep13
(#50) Add consistency to skip reasons
ef641f7 
Try to be consistent in the wording used in the reason when skipping a
task.
gep13 added a commit that referenced this issue May 5, 2022
@gep13
Merge branch 'release/0.8.0'
9125bbc 
* release/0.8.0:
  (#50) Add consistency to skip reasons
  (#50) Use specific conditions in WithCriteria
  (#49) Remove criteria on testing tasks
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot