Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't exclude testing tasks when building official release #49

Closed
gep13 opened this issue May 5, 2022 · 1 comment
Closed

Don't exclude testing tasks when building official release #49

gep13 opened this issue May 5, 2022 · 1 comment
Assignees
@gep13
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.8.0

Comments

@gep13
Copy link
Member

gep13 commented May 5, 2022

This criteria was introduced to the testing tasks recently in order to be consistent with how other tasks work, however, in hindsight, I don't think we want this criteria at all, and it should be removed.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label May 5, 2022
@gep13 gep13 added this to the 0.8.0 milestone May 5, 2022
@gep13 gep13 self-assigned this May 5, 2022
@gep13 gep13 closed this as completed May 5, 2022
gep13 added a commit that referenced this issue May 5, 2022
@gep13
(#49) Remove criteria on testing tasks
be6fae7 
The criteria for only running these tasks when not doing an official
release means that these tasks will not run on the TeamCity server,
which is really one of the main places that we want this to happen.

In hindsight, these criteria likely shouldn't have ever been added.
gep13 added a commit that referenced this issue May 5, 2022
@gep13
Merge branch 'release/0.8.0'
9125bbc 
* release/0.8.0:
  (#50) Add consistency to skip reasons
  (#50) Use specific conditions in WithCriteria
  (#49) Remove criteria on testing tasks
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot