Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure execution of release notes export #25

Closed
gep13 opened this issue Mar 17, 2022 · 1 comment
Closed

Ensure execution of release notes export #25

gep13 opened this issue Mar 17, 2022 · 1 comment
Assignees
@gep13
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.3.0

Comments

@gep13
Copy link
Member

gep13 commented Mar 17, 2022

The Recipe has the concept of an Export-Release-Notes task, which is intended to export the published release notes for a release, to then embed them within the application that is being built.

This is done for example within the Chocolatey GUI application.

However, the step that perform the export is not currently set as a dependency of any other task, therefore it is not executing at all.

This task needs to be correctly hooked up to ensure that it is ran, when it needs to be.
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Mar 17, 2022
@gep13 gep13 added this to the 0.3.0 milestone Mar 17, 2022
@gep13 gep13 self-assigned this Mar 17, 2022
@gep13 gep13 closed this as completed Mar 17, 2022
gep13 added a commit that referenced this issue Mar 17, 2022
@gep13
(#25) Update dependencies of Package task
5771be1 
To ensure that the exporting of release notes is performed, if allowed,
as part of the overall build. This dependency was missed/removed while
bringing over the functionality of GitReleaseManager from Cake.Recipe.
gep13 added a commit that referenced this issue Mar 17, 2022
@gep13
Merge branch 'release/0.3.0'
8d680ee 
* release/0.3.0:
  (#26) Ensure PrintVariables collection is used
  (#24) Correctly assert branch name
  (#22) Remove concept of IsMainRepsitory
  (#25) Update dependencies of Package task
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot