Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove concept of IsMainRepository checks #22

Closed
gep13 opened this issue Mar 17, 2022 · 1 comment
Closed

Remove concept of IsMainRepository checks #22

gep13 opened this issue Mar 17, 2022 · 1 comment
Assignees
@gep13
Labels
BreakingChange The issue will introduce backwards incompatible changes
Milestone
0.3.0

Comments

@gep13
Copy link
Member

gep13 commented Mar 17, 2022 •
edited
Loading

When this was first introduced it was based off how AppVeyor does it in terms of project name, and it was a simple check to ensure that the CI build was happening on the intended project. This is not as simple in TeamCity, and we need to find a way to associate a TeamCity Build Configuration as being against the intended repository.

This will be done in a follow up issue, and this issue is simply about removing this check completely.
@gep13 gep13 added the BreakingChange The issue will introduce backwards incompatible changes label Mar 17, 2022
@gep13 gep13 added this to the 0.3.0 milestone Mar 17, 2022
@gep13 gep13 self-assigned this Mar 17, 2022
@gep13 gep13 mentioned this issue Mar 17, 2022
Open
@gep13 gep13 closed this as completed Mar 17, 2022
gep13 added a commit that referenced this issue Mar 17, 2022
@gep13
(#22) Remove concept of IsMainRepsitory
81cace0 
This is currently not working as expected as it is based on how
AppVeyor worked, and needs to be ro-thought in terms of how TeamCity
and other providers work.

A follow up issue has been created to add this back into a future
release.
gep13 added a commit that referenced this issue Mar 17, 2022
@gep13
Merge branch 'release/0.3.0'
8d680ee 
* release/0.3.0:
  (#26) Ensure PrintVariables collection is used
  (#24) Correctly assert branch name
  (#22) Remove concept of IsMainRepsitory
  (#25) Update dependencies of Package task
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
BreakingChange The issue will introduce backwards incompatible changes
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot