Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors and warnings #478

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix errors and warnings #478

merged 3 commits into from
Sep 16, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Sep 13, 2024

When running exampleSite with latest hugo version 0.134.2, an error and multiple warnings are thrown:

ERROR deprecated: .Site.DisqusShortname was deprecated in Hugo v0.120.0 and will be removed in Hugo 0.135.0.
Use .Site.Config.Services.Disqus.Shortname instead.

This PR fixes all these issues.

Signed-off-by: Andreas Deininger <[email protected]>
@chipzoller
Copy link
Owner

Thanks for the contribution!

@chipzoller chipzoller requested a review from onweru September 13, 2024 21:42
@chipzoller
Copy link
Owner

@onweru, this look good to you? I made bumps in CI so Hugo also uses 0.128.0 for now.

Copy link
Collaborator

@onweru onweru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chipzoller, this looks good.

@chipzoller chipzoller merged commit da65f2f into chipzoller:master Sep 16, 2024
3 checks passed
@deining deining deleted the fix-error branch September 16, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants