Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opengraph partial ld+json never activated #476

Merged

Conversation

barefootstache
Copy link
Contributor

@barefootstache barefootstache commented Sep 9, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bug-fix
  • Feature (functionality, design, translations, etc.)
  • Documentation change
  • Project management (tests, CI, GitHub configuration, etc.)
  • Other (please describe):

Current state

Closes #475

Proposed changes

  • add missing setting blogDir missing in the exampleSite/config/_default/params.toml which is referenced in layouts/partials/opengraph.html
  • extend opengraph partial with a more complete keywords, tags, and categories references both within the ld+json script and outside of it

Screenshots, if applicable

Checklist

  • Bug-fixes and new features: I have tested locally with the latest release of Hugo extended. This requirement is a standard.
  • Bug-fixes, new features, and doc changes: I have updated the relevant documentation as part of this PR.
  • All PRs: I have signed off (using git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.

@chipzoller chipzoller changed the title 475 bug opengraph partial Fix opengraph partial ld+json never activated Sep 13, 2024
@barefootstache
Copy link
Contributor Author

@chipzoller fixed the broken Github actions by merging PR #478 into the branch.

@chipzoller
Copy link
Owner

Thanks, was hoping to merge that one first.

@chipzoller chipzoller requested a review from onweru September 22, 2024 12:10
Copy link
Owner

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix. @onweru, can you help test and confirm safe?

@chipzoller chipzoller merged commit c7cc97c into chipzoller:master Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] opengraph partial ld+json never activated
3 participants