Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lastmod date after slash in the post header if available. #450

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

McAviti
Copy link

@McAviti McAviti commented Oct 1, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bug-fix
  • Feature (functionality, design, translations, etc.)
  • Documentation change
  • Project management (tests, CI, GitHub configuration, etc.)
  • Other (please describe):

Current state

If a post has a last modified attribute ("lastmod"), this is not visible in the rendered article.

Issue Number(s):

Proposed changes

If a post has a "lastmod" metadata attribute is present, it is added after the creation date, separated by a slash.

Screenshots, if applicable

Screenshot 2023-10-02 012255

Checklist

  • Bug-fixes and new features: I have tested locally with the latest release of Hugo extended. This requirement is a standard.
  • Bug-fixes, new features, and doc changes: I have updated the relevant documentation as part of this PR.
  • All PRs: I have signed off (using git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.

@onweru
Copy link
Collaborator

onweru commented Oct 2, 2023

@McAviti,

Thanks for contributing. To show or not to show LastMod should be an opt-in feature; i.e disabled by default, with a variable in the config to turn it on.

Could you tweak this PR to satisfy that condition? If not, let me know I can help out .

@onweru onweru mentioned this pull request Oct 2, 2023
8 tasks
@McAviti
Copy link
Author

McAviti commented Oct 2, 2023

Sure @onweru , that's reasonable, I hope I got it right.
I added $showLastmod as Param, and I additionally suggest a $lastmodSeparator Param to be able to override the default "/" I arbitrarily selected. What do you think of that? Please review.

@McAviti McAviti changed the title added lastmode date after slash in the post header if available. added lastmod date after slash in the post header if available. Oct 8, 2023
@chipzoller chipzoller requested a review from onweru September 22, 2024 12:15
@chipzoller
Copy link
Owner

So so sorry to have neglected this, @McAviti. Could you signoff on your commits here, please? @onweru and I will try and get this in pronto.

@McAviti
Copy link
Author

McAviti commented Sep 30, 2024

@chipzoller - thanks for caring, I am on it, yet still have to figure out how to do the signoff, having some troubles with gh pr checkout PULL-REQUEST
Hope to have more time tomorrow.

McAviti and others added 23 commits October 6, 2024 01:44
Signed-off-by: Jokey Li <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Jokey Li <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: digitalbricklayer <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Christian Stankowic <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Christian Stankowic <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Christian Stankowic <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Christian Stankowic <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: barefootstache <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Andreas Deininger <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Andreas Deininger <[email protected]>
Signed-off-by: kdi <[email protected]>
Adding giscus.app support (similar to utterances)

Signed-off-by: Robert Terakedis <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: Andreas Deininger <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: barefootstache <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: barefootstache <[email protected]>
Signed-off-by: kdi <[email protected]>
Signed-off-by: barefootstache <[email protected]>
Signed-off-by: kdi <[email protected]>
@McAviti McAviti force-pushed the make_lastmod_visible_in_post branch from 008eb82 to 2fe82aa Compare October 5, 2024 23:44
@McAviti
Copy link
Author

McAviti commented Oct 8, 2024

@chipzoller , @onweru – I hope i got it right with the github workflow.

@chipzoller
Copy link
Owner

Yep, looks like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants