Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lastmod #449

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/lastmod #449

wants to merge 4 commits into from

Conversation

orlea
Copy link

@orlea orlea commented Sep 11, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bug-fix
  • Feature (functionality, design, translations, etc.)
  • Documentation change
  • Project management (tests, CI, GitHub configuration, etc.)
  • Other (please describe):

Current state

Once an article has been updated, it may be revised later.
I set up lastmod but it was not reflected and I could not find it in previous issues, so I added it.

Proposed changes

Screenshots, if applicable

Checklist

  • Bug-fixes and new features: I have tested locally with the latest release of Hugo extended. This requirement is a standard.
  • Bug-fixes, new features, and doc changes: I have updated the relevant documentation as part of this PR.
  • All PRs: I have signed off (using git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.

Signed-off-by: aries [email protected]

@chipzoller
Copy link
Owner

Can you show how this looks, please? Also, can you please sign off on your commits?

@chipzoller chipzoller requested a review from onweru September 11, 2023 12:35
Signed-off-by: aries <[email protected]>
Signed-off-by: aries <[email protected]>
@orlea
Copy link
Author

orlea commented Sep 11, 2023

I git rebase --signoff and force push.
Is this OK?
Also, it looks as follows
How it looks on the top page
image
How it looks on the article itself
image

@chipzoller
Copy link
Owner

Can we stack them vertically rather than horizontally? I think that'd be easier to read.

@orlea
Copy link
Author

orlea commented Sep 11, 2023

Is it like this?
It's just a line break and doesn't look good.
I would like to make it more visible but I don't know because I am not familiar with the front end. 😔

Points that I think are not good

  • Width of date
  • "share on" is out of alignment with date/tag span and above

Note: This line break correction has not yet been commit.
image

@chipzoller
Copy link
Owner

Ok, was worth a try. What do you think, @onweru ?

@onweru
Copy link
Collaborator

onweru commented Oct 2, 2023

Ok, was worth a try. What do you think, @onweru ?

@chipzoller, just seeing this.

Horizontal would be probably easier, due to spacing/line-height constraints. #450, looks like duplicate of this. It's stacked horizontally but it also lacks the clarity present here ... i.e it's not obvious that the second date is the lastmod.

@chipzoller
Copy link
Owner

Do we accept this or #450, @onweru?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants