RocketChipStage shouldn't extend ChiselStage #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make RocketChipStage it's own Stage child as opposed to a child of ChiselStage. Add a private RocketChiselStage that hacks ChiselStage to add the GenerateROMs phase. Signed-off-by: Schuyler Eldridge <[email protected]>
debs-sifive
reviewed
May 20, 2020
debs-sifive
approved these changes
May 20, 2020
Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate
RocketChiselStagethat adds appropriate modifications toChiselStagethat rocket chip needs (only modification is the addition of . RemoveChiselStagefromRocketChipStage's type hierarchy.I only spot checked that this passes
DefaultConfigand that the stack trace trimming didn't appear to break.I think that this is a better approach than to rely on access to
ChiselStage.runwhich is a method that should probably be madeprotected.Related issue: Fixes #2467
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes