Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make run function more composable #1446

Closed
wants to merge 1 commit into from

Conversation

debs-sifive
Copy link
Contributor

Could I get this onto 3.3.x so I can use it in rocket chip, please?

Related issue: chipsalliance/rocket-chip#2467

Type of change: feature request

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

This allows for ChiselStage's run function to be called externally. For example, from RocketStage.

@debs-sifive debs-sifive requested a review from a team as a code owner May 20, 2020 22:02
@seldridge
Copy link
Member

I've been thinking that Stage.run should likely be a protected method and not exposed publicly. Hence, I'd prefer a solution that avoids further expanding the ChiselStage API. However, I also want to get the underlying issue fixed quickly in Rocket Chip.

Towards this, I have an implementation of an alternative solution in chipsalliance/rocket-chip#2481. Would that be an acceptable solution?

@debs-sifive
Copy link
Contributor Author

@seldridge your solution makes sense to me!

@debs-sifive debs-sifive deleted the run-comp branch June 14, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants