Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch in push stack logic for branch instruction generation #995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bounti
Copy link

@Bounti Bounti commented Dec 11, 2024

Some invalid labels are propagated to non branch instructions when generating push stack logic with cfg.enable_branch true. The issue is due to the way the get_rand_instr is called with .include_category({BRANCH}) that does not seem to restrict properly the generated instructions. Workaround is to explicitly list accepted instructions.

Reported error when compiling generated testcases:

illegal operands `sd s11,sub_4_stack_p(s5)'

@Bounti
Copy link
Author

Bounti commented Dec 12, 2024

It seems that the issue happens when the supported_isa does not include RV32I and/or RV32C while enable_branch is on. Riscv_instr is then initialized without any branch instruction, so when calling get_instr_rand with include_category set to BRANCH the default case generates non branch instruction. I think get_instr_rand should return null if include_category was provided and allowed_instr is empty. Later on, simulation will fail as expected using DV_CHECK_RANDOMIZE_FATAL.

…o match. Simulation should fail as it is likely due to improper configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant