-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to align with rprojroot and here #20
Conversation
@chendaniely , What do you think of this? Any chance of getting this merged? |
@chendaniely , it's been over 6 weeks. Do you have any feedback? |
I was also seeing the |
@chendaniely , ping |
@chendaniely , Can I get some feedback on this? It's been nearly 6 months. Or is the project dead? I know there are conflicts to resolve, but I won't bother if there's no chance of getting it merged. |
I created py-repo-root with most of the fixes I could think of. |
hey @jamesmyatt appologies about the really delayed reponse. Thanks for the refactor (and bumping the version number). I should be able to getting around with the merge conflicts this week and then i'll merge this in! |
a315c57
to
01fef1b
Compare
alright, the conflicts have been fixed! |
closes #16 |
Major refactoring to allow the library to provide the same kind of functionality as both the rprojroot and here R libraries.
There's still lots of functionality in rprojroot and here that isn't implemented in this PR, but it's a start.
Closes #18, Closes #17