Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to align with rprojroot and here #20

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

jamesmyatt
Copy link
Contributor

@jamesmyatt jamesmyatt commented Sep 14, 2020

Major refactoring to allow the library to provide the same kind of functionality as both the rprojroot and here R libraries.

There's still lots of functionality in rprojroot and here that isn't implemented in this PR, but it's a start.

Closes #18, Closes #17

@jamesmyatt
Copy link
Contributor Author

@chendaniely , What do you think of this? Any chance of getting this merged?

@jamesmyatt
Copy link
Contributor Author

@chendaniely , it's been over 6 weeks. Do you have any feedback?

@pashminacameron
Copy link

pashminacameron commented Jan 5, 2021

I was also seeing the RecursionError issue, in a docker+conda environment scenario but I've now fixed it using a .here file. [In my case, only a subset of the project files are uploaded to the cloud run, and then pyprojroot tries really hard to find a project root file but fails, correctly. Adding a .here to the subset fixes the issue]. Thanks for the utility.

@jamesmyatt
Copy link
Contributor Author

@chendaniely , ping

@jamesmyatt
Copy link
Contributor Author

@chendaniely , Can I get some feedback on this? It's been nearly 6 months. Or is the project dead? I know there are conflicts to resolve, but I won't bother if there's no chance of getting it merged.

@pashminacameron
Copy link

I created py-repo-root with most of the fixes I could think of.

@chendaniely
Copy link
Owner

hey @jamesmyatt appologies about the really delayed reponse.

Thanks for the refactor (and bumping the version number). I should be able to getting around with the merge conflicts this week and then i'll merge this in!

@chendaniely chendaniely mentioned this pull request Mar 29, 2021
5 tasks
@chendaniely
Copy link
Owner

chendaniely commented Mar 29, 2021

alright, the conflicts have been fixed!
Just need to update the __init__.py so it doesn't break any code that does from pyprojroot import here since it currently needs to be written as from pyprojroot.here import here

@chendaniely chendaniely changed the base branch from master to dev March 29, 2021 03:31
@chendaniely
Copy link
Owner

closes #16

@chendaniely chendaniely reopened this Mar 29, 2021
@chendaniely chendaniely merged commit af825c9 into chendaniely:dev Mar 29, 2021
@jamesmyatt jamesmyatt deleted the feature/refactor branch July 19, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convergence with rprojroot add 'starting_dir' parameter
3 participants