Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence with rprojroot #18

Open
jamesmyatt opened this issue Sep 10, 2020 · 2 comments · Fixed by #20
Open

Convergence with rprojroot #18

jamesmyatt opened this issue Sep 10, 2020 · 2 comments · Fixed by #20

Comments

@jamesmyatt
Copy link
Contributor

First, thanks for making this. It's been on my TODO list for a long time: https://github.com/jamesmyatt/pyprojroot

The interface of this library is very different from that used by rprojroot. Would it be OK to change it to be closer? In particular, the main function is find_root and it takes some criterion as the main input. What do you think?

@jamesmyatt
Copy link
Contributor Author

@chendaniely , ping

@chendaniely
Copy link
Owner

hey @jamesmyatt for some reason i need to figure out what is going on with my github notifications. so appologies for not seeing the issue.

Yes, a more "full" port of rprojroot would be good, I will take a look at the PR you made.
I know the biggest function of "here" was just resolving a full path from a relative one, so that was the rationale for just making the "here" function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants