Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream repository, pyprojroot #9

Closed
chendaniely opened this issue Mar 23, 2023 · 1 comment
Closed

Sync with upstream repository, pyprojroot #9

chendaniely opened this issue Mar 23, 2023 · 1 comment

Comments

@chendaniely
Copy link

chendaniely commented Mar 23, 2023

Hello 👋 @joshpsawyer we've made a bunch of internal changes to pyprojroot. Wondering if you are potentially sync up with the repository?
My main thinking was we would make pyhere.here() as a thin wrapper around pyprojroot.here.here()? would reduce potential maintenance things on your end, and we can work on how both packages can share a common root_indicator values.

Mainly asking because I think it would be nice to have both of these packages be submitted as a pair for pyopensci and potentially a JOSS publication.

Related "upstream" issues: chendaniely/pyprojroot#40 chendaniely/pyprojroot#18 chendaniely/pyprojroot#14

@joshpsawyer
Copy link
Member

Hi @chendaniely ! Fine in theory, but my big concern is that you have no backwards compatibility with Python 2.X - I use pyhere with a lot of legacy code. Yes, 2.X has been officially sunsetted but I've encountered a lot of people in academia still writing in 2.X because they don't have time to refactor to 3.X and it's what they know. For that reason, it can't be a wrapper because it'll break legacy projects (at least my own 😎).

Please correct me if I'm mistaken, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants