Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump submodule for latest release of pybind11 #19

Closed
wants to merge 1 commit into from

Conversation

cbm755
Copy link

@cbm755 cbm755 commented Nov 13, 2022

I think this fixes building on Python 3.11. Fixes #18.


I'm not used to working with git submodules, so I hope I've done this right. The idea was to bump the including (submodule) for pybind11 to the latest release.

After this change, pip install . works for me on Python 3.11. I have not extensively tested.

I think this fixes building on Python 3.11.  Fixes cheind#18.
@cbm755
Copy link
Author

cbm755 commented Nov 19, 2022

In case its helpful for anyone else, I just figured out how to Pip-install directly from that branch:

pip install git+https://github.com/cbm755/py-lapsolver@pybind11_bump

(after usually python3 -m pip install -U pip if your OS is a little old)

@cheind
Copy link
Owner

cheind commented Nov 21, 2022

@cbm755 thanks! I hope I find the time soon to test this PR and merge. Never mind the appveyor failures, I think they are not relevant. Will add a github-actions based approach instead.

@CarlosRDomin
Copy link

Any update? This branch indeed fixes our issues on python 3.11 :)

@cheind
Copy link
Owner

cheind commented Dec 22, 2023

thanks for the PR, I've just merged a new update to pybind #20

@cheind cheind closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible built failures on Python 3.11?
3 participants