Refactor code and update specs #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved CRLF in favor of LF Signed-off-by: John McCrae <[email protected]>
tas50
changed the title
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
|
It may be safer to bump the major version of this gem before shipping it. |
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
…ted the spec tests now too Signed-off-by: John McCrae <[email protected]>
…s and corrected a test that was causing a block in execution Signed-off-by: John McCrae <[email protected]>
…s and corrected a test that was causing a block in execution Signed-off-by: John McCrae <[email protected]>
tas50
reviewed
Nov 29, 2021
tas50
reviewed
Nov 29, 2021
Signed-off-by: John McCrae <[email protected]>
tas50
reviewed
Nov 29, 2021
Signed-off-by: John McCrae <[email protected]>
lamont-granquist
approved these changes
Nov 30, 2021
Signed-off-by: John McCrae <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…moved CRLF in favor of LF
Signed-off-by: John McCrae [email protected]
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List